chrome/browser/ui/views/payments/shipping_option_view_controller.cc - Issue 2855203002: [Payments] Display the shipping option error alongside the address

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/shipping_option_view_controller.cc

Issue 2855203002: [Payments] Display the shipping option error alongside the address (Closed)

Patch Set: added tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/payments/payment_request_views_util.cc ('K') | « chrome/browser/ui/views/payments/profile_list_view_controller.cc ('k') | chrome/browser/ui/views/payments/shipping_option_view_controller_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/payments/shipping_option_view_controller.cc

diff --git a/chrome/browser/ui/views/payments/shipping_option_view_controller.cc b/chrome/browser/ui/views/payments/shipping_option_view_controller.cc

index df0bc625d41b6b414638029bcbb37ca63b4f4df7..bc3f9993dcb8266ce166e00020d599ac7a1409fc 100644

--- a/chrome/browser/ui/views/payments/shipping_option_view_controller.cc

+++ b/chrome/browser/ui/views/payments/shipping_option_view_controller.cc

@@ -43,7 +43,12 @@ class ShippingOptionItem : public PaymentRequestItemList::Item {

}

- bool CanBeSelected() const override {

+ bool IsDisabled() override {

+ // Shipping options are vetted by the website; none are disabled.

+ return false;

+ }

+ bool CanBeSelected() override {

// Shipping options are vetted by the website; they're all OK to select.

return true;

}