[Payments] Display the shipping option error alongside the address

chrome/browser/ui/views/payments/profile_list_view_controller.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/payments/profile_list_view_controller.h"
 
+#include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/views/payments/payment_request_dialog_view.h"
 #include "chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h"
 #include "chrome/browser/ui/views/payments/payment_request_row_view.h"
 #include "chrome/browser/ui/views/payments/payment_request_views_util.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/payments/content/payment_request_spec.h"
 #include "components/payments/content/payment_request_state.h"
 #include "components/payments/core/payments_profile_comparator.h"
 #include "components/payments/core/strings_util.h"
 #include "components/strings/grit/components_strings.h"
 #include "ui/base/l10n/l10n_util.h"
+#include "ui/gfx/paint_vector_icon.h"
+#include "ui/native_theme/native_theme.h"
+#include "ui/vector_icons/vector_icons.h"
 #include "ui/views/controls/button/label_button.h"
 #include "ui/views/controls/button/md_text_button.h"
 #include "ui/views/controls/image_view.h"
 #include "ui/views/layout/box_layout.h"
 #include "ui/views/layout/fill_layout.h"
 #include "ui/views/layout/grid_layout.h"
 
 namespace payments {
 
 namespace {
@@ skipping 40 matching lines @@
     return parent_view_->GetLabel(profile_);
   }
 
   void SelectedStateChanged() override {
     if (selected()) {
       parent_view_->SelectProfile(profile_);
       dialog_->GoBack();
     }
   }
 
-  bool CanBeSelected() const override {
-    return parent_view_->IsValidProfile(*profile_);
+  bool IsEnabled() override { return parent_view_->IsEnabled(profile_); }
+
+  bool CanBeSelected() override {
+    // In order to be selectable, a profile entry needs to be enabled, and the
+    // profile valid according to the controller. If either condition is false,
+    // PerformSelectionFallback() is called.
+    return IsEnabled() && parent_view_->IsValidProfile(*profile_);
   }
 
   void PerformSelectionFallback() override {
-    parent_view_->ShowEditor(profile_);
+    // If not disabled, the editor is opened to complete the invalid profile.

[anthonyvd, 2017/05/04 14:11:34]

nit: If enabled

[Mathieu, 2017/05/04 14:38:56]

Done.

+    if (IsEnabled())
+      parent_view_->ShowEditor(profile_);
   }
 
   ProfileListViewController* parent_view_;
   autofill::AutofillProfile* profile_;
   PaymentRequestDialogView* dialog_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileItem);
 };
 
 // The ProfileListViewController subtype for the Shipping address list
 // screen of the Payment Request flow.
 class ShippingProfileViewController : public ProfileListViewController {
  public:
   ShippingProfileViewController(PaymentRequestSpec* spec,
                                 PaymentRequestState* state,
                                 PaymentRequestDialogView* dialog)
       : ProfileListViewController(spec, state, dialog) {
     PopulateList();
   }
   ~ShippingProfileViewController() override {}
 
  protected:
   // ProfileListViewController:
   std::unique_ptr<views::View> GetLabel(
       autofill::AutofillProfile* profile) override {
-    return GetShippingAddressLabel(AddressStyleType::DETAILED,
-                                   state()->GetApplicationLocale(), *profile,
-                                   *spec(), *(state()->profile_comparator()));
+    if (!IsEnabled(profile)) {
+      // The error is not shown in the label itself on this screen, but the
+      // entry is disabled.
+      return GetShippingAddressLabelWithError(
+          AddressStyleType::DETAILED, state()->GetApplicationLocale(), *profile,
+          /*error=*/base::string16(), /*disabled_state=*/true);
+    }
+    return GetShippingAddressLabelWithMissingInfo(
+        AddressStyleType::DETAILED, state()->GetApplicationLocale(), *profile,
+        *(state()->profile_comparator()));
   }
 
   void SelectProfile(autofill::AutofillProfile* profile) override {
     state()->SetSelectedShippingProfile(profile);
   }
 
   void ShowEditor(autofill::AutofillProfile* profile) override {
     dialog()->ShowShippingAddressEditor(
         /*on_edited=*/base::BindOnce(
             &PaymentRequestState::SetSelectedShippingProfile,
             base::Unretained(state()), profile),
         /*on_added=*/
         base::BindOnce(&PaymentRequestState::AddAutofillShippingProfile,
                        base::Unretained(state()), /*selected=*/true),
         profile);
   }
 
   autofill::AutofillProfile* GetSelectedProfile() override {
-    return state()->selected_shipping_profile();
+    // If there are no errors with the currently selected profile, return it.
+    return spec()->selected_shipping_option_error().empty()
+               ? state()->selected_shipping_profile()
+               : nullptr;
   }
 
   bool IsValidProfile(const autofill::AutofillProfile& profile) override {
     return state()->profile_comparator()->IsShippingComplete(&profile);
   }
 
   std::vector<autofill::AutofillProfile*> GetProfiles() override {
     return state()->shipping_profiles();
   }
 
   DialogViewID GetDialogViewId() override {
     return DialogViewID::SHIPPING_ADDRESS_SHEET_LIST_VIEW;
   }
 
+  std::unique_ptr<views::View> CreateHeaderView() override {
+    if (spec()->selected_shipping_option_error().empty())
+      return nullptr;
+
+    std::unique_ptr<views::View> header_view = base::MakeUnique<views::View>();
+    // 8 pixels between the warning icon view and the text.
+    constexpr int kRowHorizontalSpacing = 8;
+    views::BoxLayout* layout = new views::BoxLayout(
+        views::BoxLayout::kHorizontal,
+        payments::kPaymentRequestRowHorizontalInsets, 0, kRowHorizontalSpacing);
+    layout->set_main_axis_alignment(
+        views::BoxLayout::MAIN_AXIS_ALIGNMENT_START);
+    layout->set_cross_axis_alignment(
+        views::BoxLayout::CROSS_AXIS_ALIGNMENT_STRETCH);
+    header_view->SetLayoutManager(layout);
+
+    std::unique_ptr<views::ImageView> warning_icon =
+        base::MakeUnique<views::ImageView>();
+    warning_icon->set_can_process_events_within_subtree(false);
+    warning_icon->SetImage(gfx::CreateVectorIcon(
+        ui::kWarningIcon, 16,
+        warning_icon->GetNativeTheme()->GetSystemColor(
+            ui::NativeTheme::kColorId_AlertSeverityHigh)));
+    header_view->AddChildView(warning_icon.release());
+
+    std::unique_ptr<views::Label> label = base::MakeUnique<views::Label>(
+        spec()->selected_shipping_option_error());
+    label->set_id(
+        static_cast<int>(DialogViewID::SHIPPING_ADDRESS_OPTION_ERROR));
+    label->SetEnabledColor(label->GetNativeTheme()->GetSystemColor(
+        ui::NativeTheme::kColorId_AlertSeverityHigh));
+    header_view->AddChildView(label.release());
+    return header_view;
+  }
+
   base::string16 GetSheetTitle() override {
     return GetShippingAddressSectionString(spec()->shipping_type());
   }
 
   int GetSecondaryButtonTextId() override {
     return IDS_AUTOFILL_ADD_ADDRESS_CAPTION;
   }
 
   int GetSecondaryButtonTag() override {
     return static_cast<int>(
@@ skipping 94 matching lines @@
 }
 
 ProfileListViewController::ProfileListViewController(
     PaymentRequestSpec* spec,
     PaymentRequestState* state,
     PaymentRequestDialogView* dialog)
     : PaymentRequestSheetController(spec, state, dialog) {}
 
 ProfileListViewController::~ProfileListViewController() {}
 
+bool ProfileListViewController::IsEnabled(autofill::AutofillProfile* profile) {
+  // Entry is disabled if it's the selected entry and there exists a shipping
+  // option error. Otherwise, it's enabled.
+  return !(profile == state()->selected_shipping_profile() &&

[anthonyvd, 2017/05/04 14:11:34]

nit: distribute the ! and expand the comment as per our discussion.

[Mathieu, 2017/05/04 14:38:56]

Done.

+           !spec()->selected_shipping_option_error().empty());
+}
+
+std::unique_ptr<views::View> ProfileListViewController::CreateHeaderView() {
+  return nullptr;
+}
+
 void ProfileListViewController::PopulateList() {
   autofill::AutofillProfile* selected_profile = GetSelectedProfile();
 
   // This must be done at Create-time, rather than construct-time, because
   // the subclass method GetProfiles can't be called in the ctor.
   for (auto* profile : GetProfiles()) {
     list_.AddItem(base::MakeUnique<ProfileItem>(profile, spec(), state(),
                                                 &list_, this, dialog(),
                                                 profile == selected_profile));
   }
 }
 
 void ProfileListViewController::FillContentView(views::View* content_view) {
-  content_view->SetLayoutManager(new views::FillLayout);
+  views::BoxLayout* layout =
+      new views::BoxLayout(views::BoxLayout::kVertical, 0, 0, 0);
+  layout->set_main_axis_alignment(views::BoxLayout::MAIN_AXIS_ALIGNMENT_START);
+  layout->set_cross_axis_alignment(
+      views::BoxLayout::CROSS_AXIS_ALIGNMENT_STRETCH);
+  content_view->SetLayoutManager(layout);
+  std::unique_ptr<views::View> header_view = CreateHeaderView();
+  if (header_view)
+    content_view->AddChildView(header_view.release());
   std::unique_ptr<views::View> list_view = list_.CreateListView();
   list_view->set_id(static_cast<int>(GetDialogViewId()));
   content_view->AddChildView(list_view.release());
 }
 
 std::unique_ptr<views::View>
 ProfileListViewController::CreateExtraFooterView() {
   std::unique_ptr<views::View> extra_view = base::MakeUnique<views::View>();
 
   extra_view->SetLayoutManager(new views::BoxLayout(
@@ skipping 10 matching lines @@
 
 void ProfileListViewController::ButtonPressed(views::Button* sender,
                                               const ui::Event& event) {
   if (sender->tag() == GetSecondaryButtonTag())
     ShowEditor(nullptr);
   else
     PaymentRequestSheetController::ButtonPressed(sender, event);
 }
 
 }  // namespace payments