runtime/vm/object.cc - Issue 2855173002: Revert "Void is not required to be `null` anymore."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 2855173002: Revert "Void is not required to be `null` anymore." (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index 8285ac3f3f5b98b1ce432bc00f5e4065fcf77189..39531c3dbc5cae3807f1d113863f62fa1e8c32bb 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -15825,7 +15825,7 @@ bool Instance::IsInstanceOf(

ASSERT(!other.IsMalformed());

ASSERT(!other.IsMalbounded());

if (other.IsVoidType()) {

- return true;

+ return false;

}

Zone* zone = Thread::Current()->zone();

const Class& cls = Class::Handle(zone, clazz());