pkg/compiler/lib/src/ssa/codegen.dart - Issue 2855173002: Revert "Void is not required to be `null` anymore."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/codegen.dart

Issue 2855173002: Revert "Void is not required to be `null` anymore." (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/ssa/codegen.dart

diff --git a/pkg/compiler/lib/src/ssa/codegen.dart b/pkg/compiler/lib/src/ssa/codegen.dart

index 5396b585fbe1cc6738475d9edb64b779ee338995..20163ce776ddf4b2ee8320a8a635b45398187239 100644

--- a/pkg/compiler/lib/src/ssa/codegen.dart

+++ b/pkg/compiler/lib/src/ssa/codegen.dart

@@ -2928,7 +2928,6 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {

DartType type = node.typeExpression;

assert(!type.isTypedef);

assert(!type.isDynamic);

- assert(!type.isVoid);

if (type.isFunctionType) {

// TODO(5022): We currently generate $isFunction checks for

// function types.