Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-allowed-by-container-policy.html

Issue 2855133004: Re-enable feature policy layout tests after bug fix. (Closed)
Patch Set: Rebased FlagExpectations/site-per-process Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-allowed-by-container-policy.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-allowed-by-container-policy.html b/third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-allowed-by-container-policy.html
index 406a03ce96de792f1d4a769d531c77537fe8d238..e01132c88ec0fce55915ef52caf2ac0c68213c84 100644
--- a/third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-allowed-by-container-policy.html
+++ b/third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-allowed-by-container-policy.html
@@ -1,32 +1,36 @@
<!DOCTYPE html>
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
-<iframe id="f1" allow="fullscreen"></iframe>
-<iframe id="f2" allow="fullscreen" allowfullscreen></iframe>
+<iframe allow="fullscreen"></iframe>
+<iframe allow="fullscreen" allowfullscreen></iframe>
<script>
var srcs = [
"resources/feature-policy-fullscreen.html",
"http://localhost:8000/feature-policy/resources/feature-policy-fullscreen.html"
];
-var f1 = document.getElementById('f1');
-var f2 = document.getElementById('f2');
-function loadFrames(iframe) {
- for (var src of srcs) {
- promise_test(function(t) {
- iframe.src = src;
- return new Promise(function(resolve, reject) {
- window.addEventListener('message', function(e) {
- resolve(e.data);
- }, { once: true });
- }).then(function(data) {
- assert_true(data.enabled, 'Document.fullscreenEnabled:');
- assert_equals(data.type, 'change', 'Document.requestFullscreen():');
- });
- }, 'Fullscreen is allowed on URL: ' + src + ' with allowfullscreen = ' + iframe.allowFullscreen);
- }
+function loadFrame(iframe, src) {
+ var allowfullscreen = iframe.allowFullscreen;
+ promise_test(function() {
+ iframe.src = src;
+ return new Promise(function(resolve, reject) {
+ window.addEventListener('message', function(e) {
+ resolve(e.data);
+ }, { once: true });
+ }).then(function(data) {
+ assert_true(data.enabled, 'Document.fullscreenEnabled:');
+ assert_equals(data.type, 'change', 'Document.requestFullscreen():');
+ });
+ }, 'Fullscreen is allowed on URL: ' + src + ' with allowfullscreen = ' +
+ allowfullscreen);
}
-loadFrames(f1);
-loadFrames(f2);
+window.onload = function() {
+ var iframes = document.getElementsByTagName('iframe');
+ for (var iframe of iframes) {
+ for (var src of srcs) {
+ loadFrame(iframe, src);
+ }
+ }
+}
</script>

Powered by Google App Engine
This is Rietveld 408576698