third_party/WebKit/LayoutTests/http/tests/feature-policy-experimental-features/vibrate-disabled-expected.txt - Issue 2855133004: Re-enable feature policy layout tests after bug fix.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/feature-policy-experimental-features/vibrate-disabled-expected.txt

Issue 2855133004: Re-enable feature policy layout tests after bug fix. (Closed)

Patch Set: Rebased FlagExpectations/site-per-process Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1

2

3 --------

4 Frame: '<!--framePath //<!--frame0-->-->'

5 --------

6 This is a testharness.js-based test.	1 This is a testharness.js-based test.

7 FAIL No iframe may call navigator.vibrate when disabled. assert_false: expected false got true	2 FAIL Navigator.vibrate disabled on URL: resources/feature-policy-vibrate.html as sert_false: navigator.vibrate(): expected false got true
	iclelland 2017/05/18 19:36:12 Does this mean that the test is currently failing? Does this mean that the test is currently failing? That vibrate is being allowed everywhere, including cross-origin frames, even when disabled via feature policy? lunalu1 2017/05/19 20:54:08 This is no longer the case. Show quoted text On 2017/05/18 at 19:36:12, iclelland wrote: > Does this mean that the test is currently failing? That vibrate is being allowed everywhere, including cross-origin frames, even when disabled via feature policy? This is no longer the case.
	3 FAIL Navigator.vibrate disabled on URL: http://localhost:8000/feature-policy-exp erimental-features/resources/feature-policy-vibrate.html assert_false: navigator .vibrate(): expected false got true

8 Harness: the test ran to completion.	4 Harness: the test ran to completion.

9	5

10

11 --------

12 Frame: '<!--framePath //<!--frame1-->-->'

13 --------

14 This is a testharness.js-based test.

15 FAIL No iframe may call navigator.vibrate when disabled. assert_false: expected false got true

16 Harness: the test ran to completion.

17

OLD	NEW