Issue 2855123002: Fix crash in TestingProfile if delete fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2855123002: Fix crash in TestingProfile if delete fails. (Closed)

Created:
3 years, 7 months ago by Matt Giuca

Modified:
3 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix crash in TestingProfile if delete fails. TestingProfile currently crashes due to an IO-allowed assert failure if the clean-up call to base::DeleteFile fails for some reason. This makes delete failures proceed silently (since delete cannot always be guaranteed to succeed). BUG=717648

Patch Set 1 #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	chrome/test/base/testing_profile.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Matt Giuca

Hi John, See bug for description. Note that there's an alternative CL: https://codereview.chromium.org/2854323002. You should ...

3 years, 7 months ago (2017-05-03 05:11:28 UTC) #2

Matt Giuca

3 years, 7 months ago (2017-05-04 03:16:55 UTC) #4

Message was sent while issue was closed.

Closing, as John chose the other one: https://codereview.chromium.org/2854323002

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages