Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Issue 2855003003: (Manually reverted) Revert of Do not kill recently killed ARC processes again (Closed)

Created:
3 years, 7 months ago by findit-for-me
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Do not kill recently killed ARC processes again (patchset #6 id:100001 of https://codereview.chromium.org/2850203003/ ) Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 468835 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I3ODRkMDc2OWRjZTEzYmQyZWZjNGFlOWJmMTNiMGZmZTg1MjNhMDMM Original issue's description: > Do not kill recently killed ARC processes again > > ARC processes sometimes respawn right after being killed. In that case, > killing them every time is just a waste of resources. > > BUG=706048 > TEST=try > TEST=Follow crbug.com/706048#c76, confirm Chrome no longer kills the > processes too often. > > Review-Url: https://codereview.chromium.org/2850203003 > Cr-Commit-Position: refs/heads/master@{#468835} > Committed: https://chromium.googlesource.com/chromium/src/+/b784d0769dce13bd2efc4ae9bf13b0ffe8523a03 TBR=lhchavez@chromium.org,cylee@chromium.org,georgesak@chromium.org,yusukes@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=706048

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -136 lines) Patch
M chrome/browser/memory/tab_manager_delegate_chromeos.h View 6 chunks +1 line, -24 lines 0 comments Download
M chrome/browser/memory/tab_manager_delegate_chromeos.cc View 5 chunks +1 line, -16 lines 0 comments Download
M chrome/browser/memory/tab_manager_delegate_chromeos_unittest.cc View 5 chunks +4 lines, -96 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
findit-for-me
Created Revert of Do not kill recently killed ARC processes again
3 years, 7 months ago (2017-05-03 01:30:40 UTC) #1
findit-for-me
Sheriffs: Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct. If ...
3 years, 7 months ago (2017-05-03 01:30:42 UTC) #3
adithyas
lgtm
3 years, 7 months ago (2017-05-03 01:42:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855003003/1
3 years, 7 months ago (2017-05-03 01:43:04 UTC) #7
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/heads/master'. nothing ...
3 years, 7 months ago (2017-05-03 01:43:48 UTC) #9
adithyas
On 2017/05/03 at 01:43:48, commit-bot wrote: > Failed to apply the patch. > On branch ...
3 years, 7 months ago (2017-05-03 01:45:12 UTC) #10
Yusuke Sato
On 2017/05/03 01:45:12, adithyas wrote: > On 2017/05/03 at 01:43:48, commit-bot wrote: > > Failed ...
3 years, 7 months ago (2017-05-03 02:07:26 UTC) #11
stgao
3 years, 7 months ago (2017-05-03 20:38:03 UTC) #13
Message was sent while issue was closed.
For record, manual revert was https://codereview.chromium.org/2855973003

Powered by Google App Engine
This is Rietveld 408576698