Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3945)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/win/enumerate_modules_model.cc

Issue 2854983002: Add the ThirdPartyModules.Uninstallable histogram. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/conflicts/msi_util_win.h ('K') | « chrome/browser/conflicts/third_party_metrics_recorder_win.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/win/enumerate_modules_model.cc
diff --git a/chrome/browser/win/enumerate_modules_model.cc b/chrome/browser/win/enumerate_modules_model.cc
index 7f02a70cfb02ea6d980dd32bd92e322879ebdeed..eeebc495905d18b1a80e1d02c80cac0bd69156e3 100644
--- a/chrome/browser/win/enumerate_modules_model.cc
+++ b/chrome/browser/win/enumerate_modules_model.cc
@@ -269,6 +269,12 @@ void ModuleEnumerator::ScanImplModule(size_t index) {
void ModuleEnumerator::ScanImplFinish() {
// TODO(chrisha): Annotate any modules that are suspicious/bad.
+ for (auto& module : *enumerated_modules_) {
+ if (module.name == L"chrome.dll") {
+ module.status = ModuleStatus::CONFIRMED_BAD;
+ module.recommended_action = RecommendedAction::UNINSTALL;
chrisha 2017/05/02 21:28:25 This is debugging code?
Patrick Monette 2017/05/29 22:04:56 Yes. Removed.
+ }
+ }
ReportThirdPartyMetrics();
« chrome/browser/conflicts/msi_util_win.h ('K') | « chrome/browser/conflicts/third_party_metrics_recorder_win.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698