Add the ThirdPartyModules.Uninstallable histogram.

chrome/browser/conflicts/module_database_win.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/conflicts/module_database_win.h"
 
 #include <algorithm>
 #include <tuple>
 
 #include "base/bind.h"
@@ skipping 13 matching lines @@
 
 }  // namespace
 
 ModuleDatabase::ModuleDatabase(
     scoped_refptr<base::SequencedTaskRunner> task_runner)
     : task_runner_(std::move(task_runner)),
       // ModuleDatabase owns |module_inspector_|, so it is safe to use
       // base::Unretained().
       module_inspector_(base::Bind(&ModuleDatabase::OnModuleInspected,
                                    base::Unretained(this))),
+      third_party_metrics_(this),
       weak_ptr_factory_(this) {}
 
 ModuleDatabase::~ModuleDatabase() {
   if (this == g_instance)
     g_instance = nullptr;
 }
 
 // static
 ModuleDatabase* ModuleDatabase::GetInstance() {
   return g_instance;
@@ skipping 325 matching lines @@
       creation_time(creation_time),
       process_type(process_type) {}
 
 ModuleDatabase::ProcessInfoKey::~ProcessInfoKey() = default;
 
 bool ModuleDatabase::ProcessInfoKey::operator<(
     const ProcessInfoKey& pik) const {
   // The key consists of the pair of (process_id, creation_time).
   // Use the std::tuple lexicographic comparison operator.
   return std::make_tuple(process_id, creation_time) <
          std::make_tuple(pik.process_id, pik.creation_time);

[chrisha, 2017/05/30 19:30:03]

Is there a reason why tie doesn't work here? (ie, by reference instead of
copying?)

[Patrick Monette, 2017/05/31 18:52:20]

I want to change it eventually but it seems too unrelated to this patch. Anyway
in this specific case process_id and creation_time are integers so there is no
real benefit in changing it.

The few time you saw it in recent code reviews was because I sometime was
forgetting to remove it.

 }
 
 // ModuleDatabase::ProcessInfoData ---------------------------------------------
 
 ModuleDatabase::ProcessInfoData::ProcessInfoData() = default;
 
 ModuleDatabase::ProcessInfoData::ProcessInfoData(const ProcessInfoData& other) =
     default;
 
 ModuleDatabase::ProcessInfoData::~ProcessInfoData() = default;