Add the ThirdPartyModules.Uninstallable histogram.

chrome/browser/conflicts/msi_util_win.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CONFLICTS_MSI_UTIL_WIN_H_
+#define CHROME_BROWSER_CONFLICTS_MSI_UTIL_WIN_H_
+
+#include <vector>
+
+#include "base/callback.h"
+#include "base/strings/string16.h"
+
+// Using the Microsoft Installer API, retrieves the path of all the components
+// for a given product. This function should be called on a thread that allows
+// access to the file system. Returns false if any error occured, including if
+// the |product_guid| passed is not a GUID.
+//
+// Note: Since testing this function is not viable, it can be overriden via
+// OverrideGetMsiComponentPaths() to allow its used inside unit tests.
+bool GetMsiComponentPaths(const base::string16& product_guid,
+                          std::vector<base::string16>* component_paths);
+
+using GetMsiComponentPathsOverride =
+    base::Callback<bool(const base::string16&, std::vector<base::string16>*)>;
+class ScopedGetMsiComponentPathsOverride {
+ public:
+  ScopedGetMsiComponentPathsOverride(
+      const GetMsiComponentPathsOverride& override);
+  ~ScopedGetMsiComponentPathsOverride();
+
+ private:
+  GetMsiComponentPathsOverride override_;
+};

[chrisha, 2017/05/02 21:28:25]

I'm not a huge fan of this pattern as there's effectively a global singleton
that is introduced. Maybe a class with an interface, and a mock implementation
of that interface for testing? And an explicit injection of an instance of that
interface?

This is slightly less "magical" and prone to abuse than introducing yet another
singleton.

[Patrick Monette, 2017/05/29 22:04:55]

Done.

+
+#endif  // CHROME_BROWSER_CONFLICTS_MSI_UTIL_WIN_H_