Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1777)

Unified Diff: cc/trees/layer_tree_host_impl_unittest.cc

Issue 2854953006: Move disable_display_vsync out of RendererSettings (Closed)
Patch Set: Fix LayoutTestSupport Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_impl_unittest.cc
diff --git a/cc/trees/layer_tree_host_impl_unittest.cc b/cc/trees/layer_tree_host_impl_unittest.cc
index 3e6e1d517960012b4964f9fb3fd7bb31d5ebe032..c0e2634984312d488aee0ba4701fdcc9c4965a74 100644
--- a/cc/trees/layer_tree_host_impl_unittest.cc
+++ b/cc/trees/layer_tree_host_impl_unittest.cc
@@ -8755,6 +8755,8 @@ class FrameSinkClient : public TestCompositorFrameSinkClient {
};
TEST_F(LayerTreeHostImplTest, ShutdownReleasesContext) {
+ constexpr bool kSynchronousComposite = true;
danakj 2017/05/04 15:36:35 can you put these beside where they are used
Alex Z. 2017/05/04 18:41:55 Done.
+ constexpr bool kDisableDisplayVsync = false;
scoped_refptr<TestContextProvider> context_provider =
TestContextProvider::Create();
FrameSinkClient test_client_(context_provider);
@@ -8762,7 +8764,7 @@ TEST_F(LayerTreeHostImplTest, ShutdownReleasesContext) {
auto compositor_frame_sink = base::MakeUnique<TestCompositorFrameSink>(
context_provider, TestContextProvider::CreateWorker(), nullptr, nullptr,
RendererSettings(), base::ThreadTaskRunnerHandle::Get().get(),
- true /* synchronous_composite */);
+ kSynchronousComposite, kDisableDisplayVsync);
compositor_frame_sink->SetClient(&test_client_);
CreateHostImpl(DefaultSettings(), std::move(compositor_frame_sink));

Powered by Google App Engine
This is Rietveld 408576698