Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/DOMDebuggerModel.js

Issue 2854853004: [DevTools] Check location for null when creating EventListener (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sdk/DOMDebuggerModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/DOMDebuggerModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/DOMDebuggerModel.js
index fc3010b634042a52ef389a75ba106975a621cf42..6f7b4b85dc7e32499cc2c2dd7ee454c950c6576a 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/DOMDebuggerModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/DOMDebuggerModel.js
@@ -44,11 +44,13 @@ SDK.DOMDebuggerModel = class extends SDK.SDKModel {
for (var payload of payloads) {
var location = this._runtimeModel.debuggerModel().createRawLocationByScriptId(
payload.scriptId, payload.lineNumber, payload.columnNumber);
+ if (!location)
+ continue;
eventListeners.push(new SDK.EventListener(
this, remoteObject, payload.type, payload.useCapture, payload.passive, payload.once,
payload.handler ? this._runtimeModel.createRemoteObject(payload.handler) : null,
- payload.originalHandler ? this._runtimeModel.createRemoteObject(payload.originalHandler) : null,
- /** @type {!SDK.DebuggerModel.Location} */ (location), null));
+ payload.originalHandler ? this._runtimeModel.createRemoteObject(payload.originalHandler) : null, location,
+ null));
}
return eventListeners;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698