Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/DOMDebuggerModel.js

Issue 2854853004: [DevTools] Check location for null when creating EventListener (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 SDK.DOMDebuggerModel = class extends SDK.SDKModel { 5 SDK.DOMDebuggerModel = class extends SDK.SDKModel {
6 /** 6 /**
7 * @param {!SDK.Target} target 7 * @param {!SDK.Target} target
8 */ 8 */
9 constructor(target) { 9 constructor(target) {
10 super(target); 10 super(target);
(...skipping 26 matching lines...) Expand all
37 if (!remoteObject.objectId) 37 if (!remoteObject.objectId)
38 return []; 38 return [];
39 39
40 var payloads = await this._agent.getEventListeners( 40 var payloads = await this._agent.getEventListeners(
41 /** @type {string} */ (remoteObject.objectId), undefined, undefined, 41 /** @type {string} */ (remoteObject.objectId), undefined, undefined,
42 (error, payloads) => error ? [] : payloads); 42 (error, payloads) => error ? [] : payloads);
43 var eventListeners = []; 43 var eventListeners = [];
44 for (var payload of payloads) { 44 for (var payload of payloads) {
45 var location = this._runtimeModel.debuggerModel().createRawLocationByScrip tId( 45 var location = this._runtimeModel.debuggerModel().createRawLocationByScrip tId(
46 payload.scriptId, payload.lineNumber, payload.columnNumber); 46 payload.scriptId, payload.lineNumber, payload.columnNumber);
47 if (!location)
48 continue;
47 eventListeners.push(new SDK.EventListener( 49 eventListeners.push(new SDK.EventListener(
48 this, remoteObject, payload.type, payload.useCapture, payload.passive, payload.once, 50 this, remoteObject, payload.type, payload.useCapture, payload.passive, payload.once,
49 payload.handler ? this._runtimeModel.createRemoteObject(payload.handle r) : null, 51 payload.handler ? this._runtimeModel.createRemoteObject(payload.handle r) : null,
50 payload.originalHandler ? this._runtimeModel.createRemoteObject(payloa d.originalHandler) : null, 52 payload.originalHandler ? this._runtimeModel.createRemoteObject(payloa d.originalHandler) : null, location,
51 /** @type {!SDK.DebuggerModel.Location} */ (location), null)); 53 null));
52 } 54 }
53 return eventListeners; 55 return eventListeners;
54 } 56 }
55 57
56 retrieveDOMBreakpoints() { 58 retrieveDOMBreakpoints() {
57 this._domModel.requestDocument(); 59 this._domModel.requestDocument();
58 } 60 }
59 61
60 /** 62 /**
61 * @return {!Array<!SDK.DOMDebuggerModel.DOMBreakpoint>} 63 * @return {!Array<!SDK.DOMDebuggerModel.DOMBreakpoint>}
(...skipping 773 matching lines...) Expand 10 before | Expand all | Expand 10 after
835 /** 837 /**
836 * @override 838 * @override
837 * @param {!SDK.DOMDebuggerModel} domDebuggerModel 839 * @param {!SDK.DOMDebuggerModel} domDebuggerModel
838 */ 840 */
839 modelRemoved(domDebuggerModel) { 841 modelRemoved(domDebuggerModel) {
840 } 842 }
841 }; 843 };
842 844
843 /** @type {!SDK.DOMDebuggerManager} */ 845 /** @type {!SDK.DOMDebuggerManager} */
844 SDK.domDebuggerManager; 846 SDK.domDebuggerManager;
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698