Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 285483003: Correctly update size when a plugin has a transform.

Created:
6 years, 7 months ago by awoloszyn
Modified:
5 years, 12 months ago
Reviewers:
Ian Vollick, ojan
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Correctly update size when a plugin has a transform. When RenderWidget::updateWidgetGeometry is called, we were using the absolute content box to set the geometry. This means if a non-translation transform were sent, this would be expanded, and the widget would scale up. BUG=254805 R=vollick@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/rendering/RenderWidget.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
awoloszyn
6 years, 7 months ago (2014-05-14 17:24:16 UTC) #1
ojan
This needs a test. Also, I'm not familiar with the history of this function, why ...
6 years, 7 months ago (2014-05-21 18:48:30 UTC) #2
awoloszyn
Sorry I had not meant to put this up for review until I had a ...
6 years, 7 months ago (2014-05-21 19:01:18 UTC) #3
MarkDodsworth
5 years, 12 months ago (2014-12-28 21:25:47 UTC) #4
On 2014/05/21 19:01:18, awoloszyn wrote:
> Sorry I had not meant to put this up for review until I had a test done. As
for
> the reason for the absolute box, it was done in 75915 (2011), to deal with
> transforms, and then we specifically undid it for FrameViews, because we had
an
> identical problem to what we are still having with plugincontainers.
> 
> On 2014/05/21 18:48:30, ojan wrote:
> > This needs a test.
> > 
> > Also, I'm not familiar with the history of this function, why do we ever use
> the
> > absolute box?

Any resolution for this yet? Waiting on a fix:
http://sourceforge.net/p/vbam/patches/48/

Powered by Google App Engine
This is Rietveld 408576698