Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: build/android/pylib/instrumentation/instrumentation_test_instance.py

Issue 2854823007: Move screenshot capture to Java-side. (Closed)
Patch Set: Move screenshot capture to Java-side. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/instrumentation/instrumentation_test_instance.py
diff --git a/build/android/pylib/instrumentation/instrumentation_test_instance.py b/build/android/pylib/instrumentation/instrumentation_test_instance.py
index 2324fca1194d3efc8ad608b40abd5fc68e5ce898..0fc69277a788ab0833b1d0166036128518bc7957 100644
--- a/build/android/pylib/instrumentation/instrumentation_test_instance.py
+++ b/build/android/pylib/instrumentation/instrumentation_test_instance.py
@@ -54,6 +54,7 @@ _CMDLINE_NAME_SEGMENT_RE = re.compile(
r' with(?:out)? \{[^\}]*\}')
_PICKLE_FORMAT_VERSION = 11
+FAILURE_SCREENSHOT_FILE = 'screenshots/test_failure.png'
class MissingSizeAnnotationError(test_exception.TestException):
def __init__(self, class_name):
@@ -653,6 +654,8 @@ class InstrumentationTestInstance(test_instance.TestInstance):
self._flags.append('--strict-mode=' + args.strict_mode)
if args.regenerate_goldens:
self._flags.append('--regenerate-goldens')
+ if args.gs_results_bucket:
mikecase (-- gone --) 2017/05/05 18:19:30 I think I actually have to change this to "args.gs
mikecase (-- gone --) 2017/05/05 18:44:16 Fixed! And tested running with --screenshot-dir lo
+ self._flags.append('--screenshot-file=%s' % FAILURE_SCREENSHOT_FILE)
if args.test_arguments:
# --test-arguments is deprecated for gtests and is in the process of

Powered by Google App Engine
This is Rietveld 408576698