Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: base/test/android/javatests/src/org/chromium/base/test/BaseJUnit4ClassRunner.java

Issue 2854823007: Move screenshot capture to Java-side. (Closed)
Patch Set: Move screenshot capture to Java-side. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/test/android/javatests/src/org/chromium/base/test/BaseJUnit4ClassRunner.java
diff --git a/base/test/android/javatests/src/org/chromium/base/test/BaseJUnit4ClassRunner.java b/base/test/android/javatests/src/org/chromium/base/test/BaseJUnit4ClassRunner.java
index 123545294772b3b0c7c667946ef031d1110dde25..3f81cef5df607c7c61c6f13fd8548e2b9a76ae29 100644
--- a/base/test/android/javatests/src/org/chromium/base/test/BaseJUnit4ClassRunner.java
+++ b/base/test/android/javatests/src/org/chromium/base/test/BaseJUnit4ClassRunner.java
@@ -12,6 +12,7 @@ import android.support.test.internal.util.AndroidRunnerParams;
import org.junit.runner.notification.RunNotifier;
import org.junit.runners.model.FrameworkMethod;
import org.junit.runners.model.InitializationError;
+import org.junit.runners.model.Statement;
import org.chromium.base.CollectionUtil;
import org.chromium.base.test.BaseTestResult.PreTestHook;
@@ -156,4 +157,10 @@ public class BaseJUnit4ClassRunner extends AndroidJUnit4ClassRunner {
}
return false;
}
+
+ @Override
+ protected Statement withAfters(FrameworkMethod method, Object test, Statement base) {
+ base = new ScreenshotOnFailureStatement(base);
+ return super.withAfters(method, test, base);
jbudorick 2017/05/05 01:21:58 nit: return super.withAfters(method, test, new
mikecase (-- gone --) 2017/05/05 18:09:19 Done!
+ }
}

Powered by Google App Engine
This is Rietveld 408576698