Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: chrome/browser/resources/settings/site_settings/add_site_dialog.js

Issue 2854753002: [MD settings] clear incognito only checkbox (Closed)
Patch Set: review changes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/site_list_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/site_settings/add_site_dialog.js
diff --git a/chrome/browser/resources/settings/site_settings/add_site_dialog.js b/chrome/browser/resources/settings/site_settings/add_site_dialog.js
index 41eecca19c87a1f0f710a7097fbe8d47d099c78f..09263f15c9151a02e78bbebd3d344f5e0718764c 100644
--- a/chrome/browser/resources/settings/site_settings/add_site_dialog.js
+++ b/chrome/browser/resources/settings/site_settings/add_site_dialog.js
@@ -41,14 +41,11 @@ Polymer({
assert(this.contentSetting);
},
- /**
- * Opens the dialog.
- * @param {string} type Whether this was launched from an Allow list or a
- * Block list.
- */
- open: function(type) {
- this.addWebUIListener('onIncognitoStatusChanged', function(isActive) {
- this.showIncognitoSessionOnly_ = isActive &&
+ /** Open the dialog. */
+ open: function() {
+ this.addWebUIListener('onIncognitoStatusChanged', function(hasIncognito) {
+ this.$.incognito.checked = false;
+ this.showIncognitoSessionOnly_ = hasIncognito &&
this.contentSetting != settings.PermissionValues.SESSION_ONLY;
}.bind(this));
this.browserProxy.updateIncognitoStatus();
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/site_list_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698