[MD settings] clear incognito only checkbox

chrome/test/data/webui/settings/site_list_tests.js

Index: chrome/test/data/webui/settings/site_list_tests.js
diff --git a/chrome/test/data/webui/settings/site_list_tests.js b/chrome/test/data/webui/settings/site_list_tests.js
index 76c91c9c8320d49e57c0800e67ef2e69b5461a16..179879f46acdd4b0c3ad6394c9e9695aaae92417 100644
--- a/chrome/test/data/webui/settings/site_list_tests.js
+++ b/chrome/test/data/webui/settings/site_list_tests.js
@@ -1161,12 +1161,26 @@ cr.define('site_list', function() {
       dialog.category = settings.ContentSettingsTypes.GEOLOCATION;
       dialog.contentSetting = settings.PermissionValues.ALLOW;
       document.body.appendChild(dialog);
+      dialog.open();

[dpapad, 2017/05/02 00:36:34]

add-site-dialog#open method expects a |type| parameter [1]. Upon further
inspection, the |type| parameter is not used anywhere in that function (guessing
obsolete). Can we update the signature of that method?

https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/site_s...

[dschuyler, 2017/05/02 01:05:22]

Done.

     });
 
     teardown(function() {
       dialog.remove();
     });
 
+    test('incognito', function() {
+      cr.webUIListenerCallback(
+          'onIncognitoStatusChanged',
+          /*hasIncognito=*/true);

[dpapad, 2017/05/02 00:36:34]

Can we remove the "=" part of the comment? "=" is for JSCompiler to indicate an
optional param, whereas an inline comment like this is to inform the reader
about the meaning of the literal value.

Also Assuming this is clang-formatted too? I was expecting more spaces, like 
/* hasIncognito */ true

[dschuyler, 2017/05/02 01:05:22]

It's part of the C++ style guide (and I find it really helpful).
Since it's not a closure comment, there's no ambiguity there.

+      assertFalse(dialog.$.incognito.checked);
+      dialog.$.incognito.checked = true;
+      // Changing the incognito status will reset the checkbox.
+      cr.webUIListenerCallback(
+          'onIncognitoStatusChanged',
+          /*hasIncognito=*/false);
+      assertFalse(dialog.$.incognito.checked);
+    });
+
     test('invalid input', function() {
       // Initially the action button should be disabled, but the error warning
       // should not be shown for an empty input.