[MD settings] clear incognito only checkbox

chrome/test/data/webui/settings/site_list_tests.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for site-list. */
 cr.define('site_list', function() {
   /**
    * An example pref with 2 blocked location items and 2 allowed. This pref
    * is also used for the All Sites category and therefore needs values for
    * all types, even though some might be blank.
@@ skipping 1143 matching lines @@
     /** @type {AddSiteDialogElement} */ var dialog;
 
     setup(function() {
       browserProxy = new TestSiteSettingsPrefsBrowserProxy();
       settings.SiteSettingsPrefsBrowserProxyImpl.instance_ = browserProxy;
       PolymerTest.clearBody();
       dialog = document.createElement('add-site-dialog');
       dialog.category = settings.ContentSettingsTypes.GEOLOCATION;
       dialog.contentSetting = settings.PermissionValues.ALLOW;
       document.body.appendChild(dialog);
+      dialog.open();

[dpapad, 2017/05/02 00:36:34]

add-site-dialog#open method expects a |type| parameter [1]. Upon further
inspection, the |type| parameter is not used anywhere in that function (guessing
obsolete). Can we update the signature of that method?

https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/site_s...

[dschuyler, 2017/05/02 01:05:22]

Done.

     });
 
     teardown(function() {
       dialog.remove();
     });
 
+    test('incognito', function() {
+      cr.webUIListenerCallback(
+          'onIncognitoStatusChanged',
+          /*hasIncognito=*/true);

[dpapad, 2017/05/02 00:36:34]

Can we remove the "=" part of the comment? "=" is for JSCompiler to indicate an
optional param, whereas an inline comment like this is to inform the reader
about the meaning of the literal value.

Also Assuming this is clang-formatted too? I was expecting more spaces, like 
/* hasIncognito */ true

[dschuyler, 2017/05/02 01:05:22]

It's part of the C++ style guide (and I find it really helpful).
Since it's not a closure comment, there's no ambiguity there.

+      assertFalse(dialog.$.incognito.checked);
+      dialog.$.incognito.checked = true;
+      // Changing the incognito status will reset the checkbox.
+      cr.webUIListenerCallback(
+          'onIncognitoStatusChanged',
+          /*hasIncognito=*/false);
+      assertFalse(dialog.$.incognito.checked);
+    });
+
     test('invalid input', function() {
       // Initially the action button should be disabled, but the error warning
       // should not be shown for an empty input.
       var input = dialog.$$('paper-input');
       assertTrue(!!input);
       assertFalse(input.invalid);
 
       var actionButton = dialog.$.add;
       assertTrue(!!actionButton);
       assertTrue(actionButton.disabled);
 
       // Simulate user input of invalid text.
       browserProxy.setIsPatternValid(false);
       var expectedPattern = 'foobarbaz';
       input.value = expectedPattern;
       input.fire('input');
 
       return browserProxy.whenCalled('isPatternValid').then(function(pattern) {
         assertEquals(expectedPattern, pattern);
         assertTrue(actionButton.disabled);
         assertTrue(input.invalid);
       });
     });
   });
 
   return {
     registerTests: registerTests,
   };
 });