bluetooth: macOS: BluetoothLowEnergyDeviceMac::IsConnectable() not implemented

device/bluetooth/bluetooth_adapter_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/bluetooth_adapter.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
@@ skipping 877 matching lines @@
   EXPECT_EQ(2u, result.size());
   for (const auto& pair : result) {
     EXPECT_TRUE(adapter_->GetDevice(pair.first->GetAddress()));
     EXPECT_TRUE(pair.second.empty());
   }
   EXPECT_EQ(BluetoothDevice::UUIDSet({BluetoothUUID(kTestUUIDGenericAccess)}),
             RetrieveConnectedPeripheralServiceUUIDs());
   EXPECT_EQ(2, observer.device_added_count());
   EXPECT_EQ(2u, adapter_->GetDevices().size());
 }
+#endif  // defined(OS_MACOSX)

[ortuno, 2017/05/04 01:11:49]

I'm OK with this change here but could you update the description to call out
the change and the reason for it?

[jlebel, 2017/05/04 16:38:49]

Done.

[jlebel, 2017/05/04 16:50:31]

crrev.com/2863643003

 
 // Simulate two devices being connected before calling
 // RetrieveGattConnectedDevicesWithDiscoveryFilter() with one service filter.
+#if defined(OS_MACOSX)
 TEST_F(BluetoothTest, DiscoverConnectedLowEnergyDeviceWithFilter) {
   if (!PlatformSupportsLowEnergy()) {
     LOG(WARNING) << "Low Energy Bluetooth unavailable, skipping unit test.";
     return;
   }
   InitWithFakeAdapter();
   TestBluetoothAdapterObserver observer(adapter_);
 
   SimulateConnectedLowEnergyDevice(ConnectedDeviceType::GENERIC_DEVICE);
   SimulateConnectedLowEnergyDevice(ConnectedDeviceType::HEART_RATE_DEVICE);
   BluetoothDiscoveryFilter discovery_filter(BLUETOOTH_TRANSPORT_LE);
   device::BluetoothUUID heart_service_uuid =
       device::BluetoothUUID(kTestUUIDHeartRate);
   discovery_filter.AddUUID(heart_service_uuid);
   std::unordered_map<BluetoothDevice*, BluetoothDevice::UUIDSet> result =
       adapter_->RetrieveGattConnectedDevicesWithDiscoveryFilter(
           discovery_filter);
 
   EXPECT_EQ(1u, result.size());
   for (const auto& pair : result) {
     EXPECT_EQ(kTestDeviceAddress2, pair.first->GetAddress());
     EXPECT_TRUE(adapter_->GetDevice(pair.first->GetAddress()));
     EXPECT_EQ(BluetoothDevice::UUIDSet({heart_service_uuid}), pair.second);
   }
   EXPECT_EQ(BluetoothDevice::UUIDSet({heart_service_uuid}),
             RetrieveConnectedPeripheralServiceUUIDs());
   EXPECT_EQ(1, observer.device_added_count());
   EXPECT_EQ(1u, adapter_->GetDevices().size());
 }
+#endif  // defined(OS_MACOSX)
 
 // Simulate two devices being connected before calling
 // RetrieveGattConnectedDevicesWithDiscoveryFilter() with one service filter
 // that doesn't match.
+#if defined(OS_MACOSX)
 TEST_F(BluetoothTest, DiscoverConnectedLowEnergyDeviceWithWrongFilter) {
   if (!PlatformSupportsLowEnergy()) {
     LOG(WARNING) << "Low Energy Bluetooth unavailable, skipping unit test.";
     return;
   }
   InitWithFakeAdapter();
   TestBluetoothAdapterObserver observer(adapter_);
 
   SimulateConnectedLowEnergyDevice(ConnectedDeviceType::GENERIC_DEVICE);
   SimulateConnectedLowEnergyDevice(ConnectedDeviceType::HEART_RATE_DEVICE);
   BluetoothDiscoveryFilter discovery_filter(BLUETOOTH_TRANSPORT_LE);
   discovery_filter.AddUUID(device::BluetoothUUID(kTestUUIDLinkLoss));
   std::unordered_map<BluetoothDevice*, BluetoothDevice::UUIDSet> result =
       adapter_->RetrieveGattConnectedDevicesWithDiscoveryFilter(
           discovery_filter);
 
   EXPECT_TRUE(result.empty());
   EXPECT_EQ(
       BluetoothDevice::UUIDSet({device::BluetoothUUID(kTestUUIDLinkLoss)}),
       RetrieveConnectedPeripheralServiceUUIDs());
   EXPECT_EQ(0, observer.device_added_count());
   EXPECT_EQ(0u, adapter_->GetDevices().size());
 }
+#endif  // defined(OS_MACOSX)
 
 // Simulate two devices being connected before calling
 // RetrieveGattConnectedDevicesWithDiscoveryFilter() with two service filters
 // that both match.
+#if defined(OS_MACOSX)
 TEST_F(BluetoothTest, DiscoverConnectedLowEnergyDeviceWithTwoFilters) {
   if (!PlatformSupportsLowEnergy()) {
     LOG(WARNING) << "Low Energy Bluetooth unavailable, skipping unit test.";
     return;
   }
   InitWithFakeAdapter();
   TestBluetoothAdapterObserver observer(adapter_);
 
   SimulateConnectedLowEnergyDevice(ConnectedDeviceType::GENERIC_DEVICE);
   SimulateConnectedLowEnergyDevice(ConnectedDeviceType::HEART_RATE_DEVICE);
@@ skipping 21 matching lines @@
       // Unknown device.
       EXPECT_TRUE(false);
     }
   }
   EXPECT_EQ(
       BluetoothDevice::UUIDSet({generic_service_uuid, heart_service_uuid}),
       RetrieveConnectedPeripheralServiceUUIDs());
   EXPECT_EQ(2, observer.device_added_count());
   EXPECT_EQ(2u, adapter_->GetDevices().size());
 }
+#endif  // defined(OS_MACOSX)
 
 // Simulate two devices being connected before calling
 // RetrieveGattConnectedDevicesWithDiscoveryFilter() with one service filter
 // that one match device, and then
 // RetrieveGattConnectedDevicesWithDiscoveryFilter() again.
+#if defined(OS_MACOSX)
 TEST_F(BluetoothTest, DiscoverConnectedLowEnergyDeviceTwice) {
   if (!PlatformSupportsLowEnergy()) {
     LOG(WARNING) << "Low Energy Bluetooth unavailable, skipping unit test.";
     return;
   }
   InitWithFakeAdapter();
   TestBluetoothAdapterObserver observer(adapter_);
 
   SimulateConnectedLowEnergyDevice(ConnectedDeviceType::GENERIC_DEVICE);
   SimulateConnectedLowEnergyDevice(ConnectedDeviceType::HEART_RATE_DEVICE);
@@ skipping 29 matching lines @@
   }
   EXPECT_EQ(BluetoothDevice::UUIDSet({heart_service_uuid}),
             RetrieveConnectedPeripheralServiceUUIDs());
 
   EXPECT_EQ(0, observer.device_added_count());
   EXPECT_EQ(1u, adapter_->GetDevices().size());
 }
 #endif  // defined(OS_MACOSX)
 
 }  // namespace device