Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java

Issue 2854643002: [Android] Width constrain bookmarks and downloads UIs (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
index b8267521800868fc97ab0b8fc7262522c9cb10a2..e0eb4cf7f51b43fcfc8c99baaba7a07ca4a9be02 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
@@ -22,7 +22,6 @@ import org.chromium.chrome.browser.widget.TintedImageButton;
import org.chromium.chrome.browser.widget.TintedImageView;
import org.chromium.chrome.browser.widget.selection.SelectableItemView;
import org.chromium.ui.UiUtils;
-import org.chromium.ui.base.DeviceFormFactor;
/**
* The view for a downloaded item displayed in the Downloads list.
@@ -62,7 +61,7 @@ public class DownloadItemView extends SelectableItemView<DownloadHistoryItemWrap
*/
public DownloadItemView(Context context, AttributeSet attrs) {
super(context, attrs);
- mMargin = context.getResources().getDimensionPixelSize(R.dimen.downloads_item_margin);
+ mMargin = context.getResources().getDimensionPixelSize(R.dimen.list_item_default_margin);
mIconBackgroundColor = DownloadUtils.getIconBackgroundColor(context);
mIconBackgroundColorSelected =
ApiCompatibilityUtils.getColor(context.getResources(), R.color.google_grey_600);
@@ -106,10 +105,6 @@ public class DownloadItemView extends SelectableItemView<DownloadHistoryItemWrap
mItem.cancel();
}
});
-
- if (!DeviceFormFactor.isLargeTablet(getContext())) {
- setLateralMarginsForDefaultDisplay(mLayoutContainer);
- }
}
@Override
@@ -232,13 +227,6 @@ public class DownloadItemView extends SelectableItemView<DownloadHistoryItemWrap
updateIconView();
}
- @Override
- public void setBackgroundResourceForGroupPosition(
- boolean isFirstInGroup, boolean isLastInGroup) {
- if (DeviceFormFactor.isLargeTablet(getContext())) return;
- super.setBackgroundResourceForGroupPosition(isFirstInGroup, isLastInGroup);
- }
-
private void updateIconView() {
if (isChecked()) {
mIconView.setBackgroundColor(mIconBackgroundColorSelected);

Powered by Google App Engine
This is Rietveld 408576698