Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPromoHeader.java

Issue 2854643002: [Android] Width constrain bookmarks and downloads UIs (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPromoHeader.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPromoHeader.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPromoHeader.java
index 40e949ac0205bd2ce83fd54739cc68d75fcda5b2..3ab7d47750a9c08098323f24273fd559d7eaa75f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPromoHeader.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPromoHeader.java
@@ -10,6 +10,7 @@ import android.support.v7.widget.RecyclerView;
import android.support.v7.widget.RecyclerView.ViewHolder;
import android.view.ViewGroup;
+import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.ContextUtils;
import org.chromium.base.VisibleForTesting;
import org.chromium.base.metrics.RecordUserAction;
@@ -105,8 +106,13 @@ class BookmarkPromoHeader implements AndroidSyncSettingsObserver,
}
};
- return new ViewHolder(
- SigninAndSyncView.create(parent, listener, SigninAccessPoint.BOOKMARK_MANAGER)) {};
+ SigninAndSyncView view =
+ SigninAndSyncView.create(parent, listener, SigninAccessPoint.BOOKMARK_MANAGER);
+ // A MarginResizer is used to apply margins in regular and wide display modes. Remove the
+ // view's lateral padding so that margins can be used instead.
+ ApiCompatibilityUtils.setPaddingRelative(
+ view, 0, view.getPaddingTop(), 0, view.getPaddingBottom());
+ return new ViewHolder(view) {};
}
/**

Powered by Google App Engine
This is Rietveld 408576698