Issue 285453002: ServiceWorker: Clean up ServiceWorkerDatabaseTest (2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 285453002: ServiceWorker: Clean up ServiceWorkerDatabaseTest (2) (Closed)

Created:
6 years, 7 months ago by nhiroki

Modified:
6 years, 7 months ago

Reviewers:
michaeln

CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ServiceWorker: Clean up ServiceWorkerDatabaseTest (2) Part 1: https://codereview.chromium.org/282533002/ BUG=n/a TEST=content_unittests --gtest_filter=ServiceWorkerDatabaseTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269940

Patch Set 2 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -81 lines)			Patch
	M	content/browser/service_worker/service_worker_database_unittest.cc	View	1	20 chunks	+47 lines, -81 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

nhiroki

PTAL, thanks! https://codereview.chromium.org/285453002/diff/1/content/browser/service_worker/service_worker_database_unittest.cc File content/browser/service_worker/service_worker_database_unittest.cc (left): https://codereview.chromium.org/285453002/diff/1/content/browser/service_worker/service_worker_database_unittest.cc#oldcode353 content/browser/service_worker/service_worker_database_unittest.cc:353: // should be calculated automatically. I found ...

6 years, 7 months ago (2014-05-12 15:14:24 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/285453002/20001

6 years, 7 months ago (2014-05-12 22:51:13 UTC) #4

Message was sent while issue was closed.

Change committed as 269940

Expand Messages | Collapse Messages

Issue 285453002: ServiceWorker: Clean up ServiceWorkerDatabaseTest (2) (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages