Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chrome/browser/resources/settings/site_settings/edit_exception_dialog.js

Issue 2854523002: [MD settings] do not send embedded origin when editing (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/site_settings/edit_exception_dialog.js
diff --git a/chrome/browser/resources/settings/site_settings/edit_exception_dialog.js b/chrome/browser/resources/settings/site_settings/edit_exception_dialog.js
index bc5cc80243014c250b17c70c493a15db63e53a58..6e7070a9dd7d60eef1dcd169c5dd340285b4ae12 100644
--- a/chrome/browser/resources/settings/site_settings/edit_exception_dialog.js
+++ b/chrome/browser/resources/settings/site_settings/edit_exception_dialog.js
@@ -51,9 +51,8 @@ Polymer({
// The way to "edit" an exception is to remove it and and a new one.
this.browserProxy_.resetCategoryPermissionForOrigin(
this.model.origin,
- this.model.embeddingOrigin,
- this.model.category,
- this.model.incognito);
+ '', // Do not send an embeddedOrigin when editing.
+ this.model.category, this.model.incognito);
this.browserProxy_.setCategoryPermissionForOrigin(
this.origin_,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698