Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2854523002: [MD settings] do not send embedded origin when editing (Closed)

Created:
3 years, 7 months ago by dschuyler
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] do not send embedded origin when editing It may be better to remove the "edit" option from the action menu, rather than create a new entry. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/resources/settings/site_settings/edit_exception_dialog.js View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (5 generated)
dschuyler
Description was changed from ========== [MD settings] do not send embedded origin when editing It ...
3 years, 7 months ago (2017-04-29 00:53:01 UTC) #1
dschuyler
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-04-29 00:53:03 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854523002/1
3 years, 7 months ago (2017-04-29 00:53:27 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-04-29 01:50:29 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-04-29 01:50:30 UTC) #5
Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698