third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp - Issue 2854493002: Store previous painting clip rects on FragmentData.

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Issue 2854493002: Store previous painting clip rects on FragmentData. (Closed)

Patch Set: none Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

index 5fabc8b6b331dd680bc71dcfeb766323e5534803..f8f95a6816b682b02efa19170a8793003fb26772 100644

--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

@@ -1191,7 +1191,14 @@ void PaintPropertyTreeBuilder::UpdatePaintProperties(

NeedsFilter(object) || NeedsCssClip(object) ||

NeedsScrollbarPaintOffset(object) || NeedsOverflowScroll(object) ||

NeedsPerspective(object) || NeedsSVGLocalToBorderBoxTransform(object) ||

- NeedsScrollTranslation(object) || NeedsCssClipFixedPosition(object);

+ NeedsScrollTranslation(object) ||

+ NeedsCssClipFixedPosition(object)

+ // These are neeed because we store previous painting clip rects on

wkorman 2017/05/01 20:29:24 neeed -> needed

+ // ObjectPaintProperties.

wkorman 2017/05/01 20:29:24 Comment looks stale -- we're storing them in Fragm

+ ||

+ (object.HasLayer() &&

+ ToLayoutBoxModelObject(object).Layer()->SupportsSubsequenceCaching()) ||

wkorman 2017/05/01 20:29:24 How does subsequence caching support on a layer me

chrishtr 2017/05/01 21:43:54 I no longer need this code actually, now that the

+ object.HasClipRelatedProperty();

bool had_paint_properties = object.PaintProperties();