Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2854443002: [Mojo Video Capture] Implement a VideoCaptureProvider that uses the video capture service

Created:
3 years, 7 months ago by chfremer
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, chfremer+watch_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin-cc_chromium.org, alokp+watch_chromium.org, darin (slow to review), xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mojo Video Capture] Implement a VideoCaptureProvider that uses the video capture service This CL is part of the Mojo Video Capture work. For the bigger picture, see [1] CL24. The interface content::VideoCaptureProvider currently has one implementation called InProcessVideoCaptureProvider, which is essentially a factory for the legacy in-process video capture stack. This CL adds a second implementation called MojoServiceVideoCaptureProvider which is essentially a wrapper for connecting to and communicating with the new video capture service. The new implementation is not yet hooked up to anything. This will be done in the subsequent CL25. BUG=584797 TEST= service_unittests --gtest_filter="*Video*" content_unittests --gtest_filter="*Video*" content_browsertests --gtest_filter="VideoCaptureBrowserTest.*" [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+504 lines, -0 lines) Patch
M content/browser/BUILD.gn View 2 chunks +8 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/in_process_video_capture_provider.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/in_process_video_capture_provider.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/mock_video_capture_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
A content/browser/renderer_host/media/mojo_service_launched_video_capture_device.h View 1 chunk +57 lines, -0 lines 0 comments Download
A content/browser/renderer_host/media/mojo_service_launched_video_capture_device.cc View 1 chunk +104 lines, -0 lines 0 comments Download
A content/browser/renderer_host/media/mojo_service_video_capture_device_launcher.h View 1 chunk +61 lines, -0 lines 0 comments Download
A content/browser/renderer_host/media/mojo_service_video_capture_device_launcher.cc View 1 chunk +127 lines, -0 lines 0 comments Download
A content/browser/renderer_host/media/mojo_service_video_capture_provider.h View 1 chunk +43 lines, -0 lines 0 comments Download
A content/browser/renderer_host/media/mojo_service_video_capture_provider.cc View 1 chunk +87 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_provider.h View 1 chunk +2 lines, -0 lines 0 comments Download
M services/video_capture/public/cpp/receiver_media_to_mojo_adapter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M services/video_capture/public/cpp/receiver_media_to_mojo_adapter.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Depends on Patchset:

Powered by Google App Engine
This is Rietveld 408576698