net/http/http_transaction_test_util.cc - Issue 2854433002: Combine and make const RequiresValidation() and ConditionalizeRequest().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_transaction_test_util.cc

Issue 2854433002: Combine and make const RequiresValidation() and ConditionalizeRequest().

Patch Set: Restructure code, execute todos, fix GetConnectionAttempts. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_transaction_test_util.cc

diff --git a/net/http/http_transaction_test_util.cc b/net/http/http_transaction_test_util.cc

index a5b57461df5a2e49568fa045bc285f9d01e006bc..2d9c7be7f182adfd86f470bad8c6799ed2716010 100644

--- a/net/http/http_transaction_test_util.cc

+++ b/net/http/http_transaction_test_util.cc

@@ -488,7 +488,8 @@ int MockNetworkTransaction::ResumeNetworkStart() {

void MockNetworkTransaction::GetConnectionAttempts(

ConnectionAttempts* out) const {

- NOTIMPLEMENTED();

+ // A mock transaction makes no connection attempts.

+ return;

}

void MockNetworkTransaction::CallbackLater(const CompletionCallback& callback,