Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: components/web_restrictions/browser/web_restrictions_resource_throttle_unittest.cc

Issue 2854423003: Mark a WebRestrictionsResourceThrottleTest test flaky (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/web_restrictions/browser/web_restrictions_resource_throttle_unittest.cc
diff --git a/components/web_restrictions/browser/web_restrictions_resource_throttle_unittest.cc b/components/web_restrictions/browser/web_restrictions_resource_throttle_unittest.cc
index f92951cd739dece2340c943c2815c1b2184ef178..933bb32656931883e5e8ff0bbd7db6271d792d81 100644
--- a/components/web_restrictions/browser/web_restrictions_resource_throttle_unittest.cc
+++ b/components/web_restrictions/browser/web_restrictions_resource_throttle_unittest.cc
@@ -114,7 +114,15 @@ TEST_F(WebRestrictionsResourceThrottleTest, WillStartRequest_DeferredForbid) {
EXPECT_EQ(net::ERR_BLOCKED_BY_ADMINISTRATOR, delegate_.GetErrorCode());
}
-TEST_F(WebRestrictionsResourceThrottleTest, WillStartRequest_Subresource) {
+#if defined(OS_ANDROID)
+// Flaky on android: https://crbug.com/718066
+#define MAYBE_WillStartRequest_Subresource DISABLED_WillStartRequest_Subresource
+#else
+#define MAYBE_WillStartRequest_Subresource WillStartRequest_Subresource
+#endif
+
+TEST_F(WebRestrictionsResourceThrottleTest,
+ MAYBE_WillStartRequest_Subresource) {
// Only the main frame should be deferred.
// Initialization of the delegate is asynchronous, and this will only work
// correctly if the provider is initialized. Run a main frame through this
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698