[omnibox] Use suggestion instead of input for base text

components/omnibox/browser/base_search_provider.cc

Index: components/omnibox/browser/base_search_provider.cc
diff --git a/components/omnibox/browser/base_search_provider.cc b/components/omnibox/browser/base_search_provider.cc
index 51e9d5b5c8c3ab7d461493d0300122bd254275ac..eea0710c99426f1e79534bf61a9c369d00306ddf 100644
--- a/components/omnibox/browser/base_search_provider.cc
+++ b/components/omnibox/browser/base_search_provider.cc
@@ -253,8 +253,8 @@ AutocompleteMatch BaseSearchProvider::CreateSearchSuggestion(
   match.answer = SuggestionAnswer::copy(suggestion.answer());
   match.subtype_identifier = suggestion.subtype_identifier();
   if (suggestion.type() == AutocompleteMatchType::SEARCH_SUGGEST_TAIL) {
-    match.RecordAdditionalInfo(
-        kACMatchPropertyInputText, base::UTF16ToUTF8(input.text()));
+    match.RecordAdditionalInfo(kACMatchPropertyContentsText,

[Peter Kasting, 2017/05/06 20:13:07]

Is this the right name for this?  It seems like suggestion() is distinct from
match_contents() (used above), though I'm not sure I understand precisely how.

[Kevin Bailey, 2017/05/06 21:55:01]

I could work 'suggestion' into the name if you like, but it seems like a subtle
difference to me.

[Peter Kasting, 2017/05/10 20:38:11]

I think that's why I'm worried about this -- this property is not being set to
the contents, but to something else, and when I don't know what the difference
really is, I don't know how worried to be.

kACMatchPropertySuggestionText?

[Kevin Bailey, 2017/05/11 13:27:37]

Done.

+                               base::UTF16ToUTF8(suggestion.suggestion()));
     match.RecordAdditionalInfo(
         kACMatchPropertyContentsPrefix,
         base::UTF16ToUTF8(suggestion.match_contents_prefix()));