MD Settings: Add feature flag for showing content settings in a per-origin view.

chrome/common/chrome_switches.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Defines the shared command-line switches used by code in the Chrome
 // directory that don't have anywhere more specific to go.
 
 #ifndef CHROME_COMMON_CHROME_SWITCHES_H_
 #define CHROME_COMMON_CHROME_SWITCHES_H_
 
@@ skipping 112 matching lines @@
 extern const char kEnableOfflineAutoReload[];
 extern const char kEnableOfflineAutoReloadVisibleOnly[];
 extern const char kEnablePermissionActionReporting[];
 extern const char kEnablePotentiallyAnnoyingSecurityFeatures[];
 extern const char kEnablePowerOverlay[];
 extern const char kEnablePrintPreviewRegisterPromos[];
 extern const char kEnableProfiling[];
 extern const char kEnablePushApiBackgroundMode[];
 extern const char kEnableQuic[];
 extern const char kEnableSettingsWindow[];
+extern const char kEnableSiteDetails[];

[dominickn, 2017/05/05 02:58:53]

Instead of having a switch, can you add a feature instead? Features are the
"right way" to do this now. For instance, you can have a look at
features::kModalPermissionPrompts, which has a chrome://flags entry and can be
enabled on the command line with --enable-features=ModalPermissionPrompts.

It's not that much different from your CL now:
 - add the feature in chrome/common/chrome_features*
 - remove the switch
 - change the about:flags entry and histograms value to pick up the feature

I looked at the CL where site settings added this flag and it looks like they
were a bit behind the times when they added it (crrev.com/2409003002)

[Patti Lor, 2017/05/05 08:45:21]

Done, thank you!

 extern const char kEnableSiteEngagementEvictionPolicy[];
 extern const char kEnableSiteSettings[];
 extern const char kEnableSupervisedUserManagedBookmarksFolder[];
 extern const char kEnableTabAudioMuting[];
 extern const char kEnableThumbnailRetargeting[];
 extern const char kEnableUserAlternateProtocolPorts[];
 extern const char kEnableWebNotificationCustomLayouts[];
 extern const char kEnableWebRtcEventLoggingFromExtension[];
 extern const char kExtensionContentVerification[];
 extern const char kExtensionContentVerificationBootstrap[];
@@ skipping 228 matching lines @@
 #if defined(OS_WIN)
 bool GDITextPrintingEnabled();
 #endif
 
 // DON'T ADD RANDOM STUFF HERE. Put it in the main section above in
 // alphabetical order, or in one of the ifdefs (also in order in each section).
 
 }  // namespace switches
 
 #endif  // CHROME_COMMON_CHROME_SWITCHES_H_