Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1996)

Unified Diff: runtime/vm/kernel_reader.cc

Issue 2854393002: [kernel] [partial] Streaming of kernel binary without AST nodes (Closed)
Patch Set: Address comments; small fixes; rebased. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/kernel_binary_flowgraph.cc ('k') | runtime/vm/kernel_to_il.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel_reader.cc
diff --git a/runtime/vm/kernel_reader.cc b/runtime/vm/kernel_reader.cc
index 458ad1b90e3ac166fbe5f80320904500dced7b94..1ddd641c9155bb545659bbdd721b26338da307e9 100644
--- a/runtime/vm/kernel_reader.cc
+++ b/runtime/vm/kernel_reader.cc
@@ -212,11 +212,13 @@ Object& KernelReader::ReadProgram() {
// to be patched.
if (procedure != NULL) {
// We will handle the StaticGet specially and will not use the name.
+ // Note that we pass "true" in cannot_stream to avoid trying to stream
+ // a non-existing part of the binary.
//
// TODO(kmillikin): we are leaking the new function body. Find a way to
// deallocate it.
procedure->function()->ReplaceBody(
- new ReturnStatement(new StaticGet(NameIndex())));
+ new ReturnStatement(new StaticGet(NameIndex(), false), false));
}
return library;
}
« no previous file with comments | « runtime/vm/kernel_binary_flowgraph.cc ('k') | runtime/vm/kernel_to_il.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698