[kernel] [partial] Streaming of kernel binary without AST nodes

runtime/vm/kernel.h

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_VM_KERNEL_H_
 #define RUNTIME_VM_KERNEL_H_
 
 #if !defined(DART_PRECOMPILED_RUNTIME)
 #include "platform/assert.h"
 #include "vm/allocation.h"
@@ skipping 211 matching lines @@
   // Returns element at [index].
   T*& operator[](int index) {
     ASSERT(index < length_);
     return array_[index];
   }
 
   int length() { return length_; }
 
   T** raw_array() { return array_; }
 
+  bool cannot_stream() {

[Kevin Millikin (Google), 2017/05/11 10:38:35]

This should be CanStream.  Capitalized because of the loop, and positive because
predicates should always be positive (`!CannotStream` is hard to think about).

[jensj, 2017/05/11 12:59:25]

Done.

+    for (intptr_t i = 0; i < length_; ++i) {
+      if (array_[i]->cannot_stream()) return true;
+    }
+    return false;
+  }
+
  private:
   T** array_;
   int length_;
 
   DISALLOW_COPY_AND_ASSIGN(List);
 };
 
 
 class TypeParameterList : public List<TypeParameter> {
  public:
@@ skipping 137 matching lines @@
 
 class TreeNode : public Node {
  public:
   virtual ~TreeNode();
 
   DEFINE_CASTING_OPERATIONS(TreeNode);
 
   virtual void AcceptVisitor(Visitor* visitor);
   virtual void AcceptTreeVisitor(TreeVisitor* visitor) = 0;
   intptr_t kernel_offset() const { return kernel_offset_; }
+  bool cannot_stream() { return cannot_stream_; }
 
  protected:
-  TreeNode() : kernel_offset_(-1) {}
+  TreeNode() : kernel_offset_(-1), cannot_stream_(false) {}
 
   // Offset for this node in the kernel-binary. If this node has a tag the
   // offset includes the tag. Can be -1 to indicate "unknown" or invalid offset.
   intptr_t kernel_offset_;
 
+  bool cannot_stream_;
+
  private:
   DISALLOW_COPY_AND_ASSIGN(TreeNode);
 };
 
 
 class LinkedNode : public TreeNode {
  public:
   virtual ~LinkedNode();
 
   CanonicalName* canonical_name() { return canonical_name_; }
@@ skipping 605 matching lines @@
 
   virtual void AcceptExpressionVisitor(ExpressionVisitor* visitor);
   virtual void VisitChildren(Visitor* visitor);
 
   VariableDeclaration* variable() { return variable_; }
 
  private:
   VariableGet() {}
 
   Ref<VariableDeclaration> variable_;
+  intptr_t variable_kernel_offset_;
 
   DISALLOW_COPY_AND_ASSIGN(VariableGet);
 };
 
 
 class VariableSet : public Expression {
  public:
   static VariableSet* ReadFrom(Reader* reader);
   static VariableSet* ReadFrom(Reader* reader, uint8_t payload);
 
   virtual ~VariableSet();
 
   DEFINE_CASTING_OPERATIONS(VariableSet);
 
   virtual void AcceptExpressionVisitor(ExpressionVisitor* visitor);
   virtual void VisitChildren(Visitor* visitor);
 
   VariableDeclaration* variable() { return variable_; }
   Expression* expression() { return expression_; }
 
  private:
   VariableSet() {}
 
   Ref<VariableDeclaration> variable_;
+  intptr_t variable_kernel_offset_;
   Child<Expression> expression_;
 
   DISALLOW_COPY_AND_ASSIGN(VariableSet);
 };
 
 
 class PropertyGet : public Expression {
  public:
   static PropertyGet* ReadFrom(Reader* reader);
 
@@ skipping 90 matching lines @@
   Child<Expression> receiver_;
   Ref<CanonicalName> target_reference_;  // Member.
   Child<Expression> value_;
 
   DISALLOW_COPY_AND_ASSIGN(DirectPropertySet);
 };
 
 
 class StaticGet : public Expression {
  public:
-  explicit StaticGet(CanonicalName* target) : target_reference_(target) {}
+  StaticGet(CanonicalName* target, bool cannot_stream)
+      : target_reference_(target) {
+    cannot_stream_ = cannot_stream;
+  }
 
   static StaticGet* ReadFrom(Reader* reader);
 
   virtual ~StaticGet();
 
   DEFINE_CASTING_OPERATIONS(StaticGet);
 
   virtual void AcceptExpressionVisitor(ExpressionVisitor* visitor);
   virtual void VisitChildren(Visitor* visitor);
 
@@ skipping 999 matching lines @@
  public:
   static BreakStatement* ReadFrom(Reader* reader);
 
   virtual ~BreakStatement();
 
   DEFINE_CASTING_OPERATIONS(BreakStatement);
 
   virtual void AcceptStatementVisitor(StatementVisitor* visitor);
   virtual void VisitChildren(Visitor* visitor);
 
-  LabeledStatement* target() { return target_; }
+  intptr_t target_index() { return target_index_; }
 
  private:
   BreakStatement() {}
 
-  Ref<LabeledStatement> target_;
+  intptr_t target_index_;
 
   DISALLOW_COPY_AND_ASSIGN(BreakStatement);
 };
 
 
 class WhileStatement : public Statement {
  public:
   static WhileStatement* ReadFrom(Reader* reader);
 
   virtual ~WhileStatement();
@@ skipping 165 matching lines @@
  public:
   static ContinueSwitchStatement* ReadFrom(Reader* reader);
 
   virtual ~ContinueSwitchStatement();
 
   DEFINE_CASTING_OPERATIONS(ContinueSwitchStatement);
 
   virtual void AcceptStatementVisitor(StatementVisitor* visitor);
   virtual void VisitChildren(Visitor* visitor);
 
-  SwitchCase* target() { return target_; }
+  intptr_t target_index() { return target_index_; }
 
  private:
   ContinueSwitchStatement() {}
 
-  Ref<SwitchCase> target_;
+  intptr_t target_index_;
 
   DISALLOW_COPY_AND_ASSIGN(ContinueSwitchStatement);
 };
 
 
 class IfStatement : public Statement {
  public:
   static IfStatement* ReadFrom(Reader* reader);
 
   virtual ~IfStatement();
@@ skipping 13 matching lines @@
   Child<Expression> condition_;
   Child<Statement> then_;
   Child<Statement> otherwise_;
 
   DISALLOW_COPY_AND_ASSIGN(IfStatement);
 };
 
 
 class ReturnStatement : public Statement {
  public:
-  explicit ReturnStatement(Expression* expression) : expression_(expression) {}
+  explicit ReturnStatement(Expression* expression, bool cannot_stream)

[Kevin Millikin (Google), 2017/05/11 10:38:35]

No need for explicit unless it takes only one argument.

[jensj, 2017/05/11 12:59:25]

Done.

+      : expression_(expression) {
+    cannot_stream_ = cannot_stream;
+  }
 
   static ReturnStatement* ReadFrom(Reader* reader);
 
   virtual ~ReturnStatement();
 
   DEFINE_CASTING_OPERATIONS(ReturnStatement);
 
   virtual void AcceptStatementVisitor(StatementVisitor* visitor);
   virtual void VisitChildren(Visitor* visitor);
 
@@ skipping 898 matching lines @@
 }  // namespace kernel
 
 kernel::Program* ReadPrecompiledKernelFromBuffer(const uint8_t* buffer,
                                                  intptr_t buffer_length);
 
 
 }  // namespace dart
 
 #endif  // !defined(DART_PRECOMPILED_RUNTIME)
 #endif  // RUNTIME_VM_KERNEL_H_