Make TestingProfile delete failures explicitly CHECK-fail.

chrome/test/base/testing_profile.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/base/testing_profile.h"
 
 #include <utility>
 
 #include "base/base_paths.h"
 #include "base/command_line.h"
@@ skipping 548 matching lines @@
   // Failing a post == leaks == heapcheck failure. Make that an immediate test
   // failure.
   if (resource_context_) {
     CHECK(BrowserThread::DeleteSoon(BrowserThread::IO, FROM_HERE,
                                     resource_context_));
     resource_context_ = NULL;
     content::RunAllPendingInMessageLoop(BrowserThread::IO);
   }
 
   base::ThreadRestrictions::ScopedAllowIO allow_io;
-  ignore_result(temp_dir_.Delete());
+  // Release the temp dir during the |allow_io| scope (otherwise the
+  // ScopedTempDir destructor will do it in a context where IO is not allowed).
+  // If Delete fails (other than in the valid case where the path is empty), the
+  // test will leave detritus, so fail the test.
+  if (!temp_dir_.IsEmpty()) {
+    if (!temp_dir_.Delete()) {
+      LOG(ERROR) << "CHECK(temp_dir_.Delete()) would fail!!!";
+    } else {
+      LOG(WARNING) << "Delete in ScopedAllowIO succeeded";
+    }
+  } else {
+    LOG(WARNING) << "Not calling Delete in ScopedAllowIO (path is empty)";
+  }
 }
 
 void TestingProfile::CreateFaviconService() {
   // It is up to the caller to create the history service if one is needed.
   FaviconServiceFactory::GetInstance()->SetTestingFactory(
       this, FaviconServiceFactory::GetDefaultFactory());
 }
 
 bool TestingProfile::CreateHistoryService(bool delete_file, bool no_db) {
   DestroyHistoryService();
@@ skipping 519 matching lines @@
   // Note: Owned by |original_profile|.
   return new TestingProfile(path_, delegate_,
 #if BUILDFLAG(ENABLE_EXTENSIONS)
                             extension_policy_,
 #endif
                             std::move(pref_service_), original_profile,
                             guest_session_, supervised_user_id_,
                             std::move(policy_service_), testing_factories_,
                             profile_name_);
 }