Make TestingProfile delete failures explicitly CHECK-fail.

base/files/scoped_temp_dir.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/scoped_temp_dir.h"
 
 #include "base/files/file_util.h"
 #include "base/logging.h"
 
 namespace base {
 
 ScopedTempDir::ScopedTempDir() {
 }
 
 ScopedTempDir::~ScopedTempDir() {
-  if (!path_.empty() && !Delete())
-    DLOG(WARNING) << "Could not delete temp dir in dtor.";
+  if (!path_.empty()) {
+    if (!Delete())
+      DLOG(WARNING) << "Could not delete temp dir in dtor.";
+    else
+      LOG(WARNING) << "Delete in ~ScopedTempDir succeeded";
+  } else {
+    LOG(WARNING) << "Not calling Delete in ~ScopedTempDir (path empty)";
+  }
+
+  CHECK(false) << "Deliberate crash.";
 }
 
 bool ScopedTempDir::CreateUniqueTempDir() {
   if (!path_.empty())
     return false;
 
   // This "scoped_dir" prefix is only used on Windows and serves as a template
   // for the unique name.
   if (!base::CreateNewTempDirectory(FILE_PATH_LITERAL("scoped_dir"), &path_))
     return false;
@@ skipping 23 matching lines @@
     return false;
 
   if (!DirectoryExists(path) && !base::CreateDirectory(path))
     return false;
 
   path_ = path;
   return true;
 }
 
 bool ScopedTempDir::Delete() {
-  if (path_.empty())
+  if (path_.empty()) {
+    LOG(WARNING) << "ScopedTempDir::Delete: Failing due to path being empty";
     return false;
+  }
 
   bool ret = base::DeleteFile(path_, true);
   if (ret) {
     // We only clear the path if deleted the directory.
+    LOG(WARNING)
+        << "ScopedTempDir::Delete: DeleteFile Succeeded; clearing path";
     path_.clear();
+  } else {
+    LOG(WARNING) << "ScopedTempDir::Delete: DeleteFile Failed";
   }
 
   return ret;
 }
 
 FilePath ScopedTempDir::Take() {
   FilePath ret = path_;
   path_ = FilePath();
   return ret;
 }
 
 const FilePath& ScopedTempDir::GetPath() const {
   DCHECK(!path_.empty()) << "Did you call CreateUniqueTempDir* before?";
   return path_;
 }
 
+bool ScopedTempDir::IsEmpty() const {
+  return path_.empty();
+}
+
 bool ScopedTempDir::IsValid() const {
-  return !path_.empty() && DirectoryExists(path_);
+  return !IsEmpty() && DirectoryExists(path_);
 }
 
 }  // namespace base