Make TestingProfile delete failures explicitly CHECK-fail.

base/files/file_util_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_util.h"
 
 #include <windows.h>
 #include <io.h>
 #include <psapi.h>
 #include <shellapi.h>
@@ skipping 72 matching lines @@
 
 FilePath MakeAbsoluteFilePath(const FilePath& input) {
   ThreadRestrictions::AssertIOAllowed();
   wchar_t file_path[MAX_PATH];
   if (!_wfullpath(file_path, input.value().c_str(), MAX_PATH))
     return FilePath();
   return FilePath(file_path);
 }
 
 bool DeleteFile(const FilePath& path, bool recursive) {
+  LOG(WARNING) << "base::DeleteFile: Asserting IO allowed";
   ThreadRestrictions::AssertIOAllowed();
 
-  if (path.empty())
+  LOG(WARNING) << "base::DeleteFile: IO allowed assertion is OK";
+  if (path.empty()) {
+    LOG(WARNING) << "base::DeleteFile: Succeeded (path was empty)";
     return true;
+  }
 
-  if (path.value().length() >= MAX_PATH)
+  if (path.value().length() >= MAX_PATH) {
+    LOG(WARNING) << "base::DeleteFile: Failed (path was too long)";
     return false;
+  }
 
   // Handle any path with wildcards.
   if (path.BaseName().value().find_first_of(L"*?") !=
       FilePath::StringType::npos) {
-    return DeleteFileRecursive(path.DirName(), path.BaseName().value(),
-                               recursive);
+    bool r =
+        DeleteFileRecursive(path.DirName(), path.BaseName().value(), recursive);
+    LOG(WARNING) << "base::DeleteFile: " << (r ? "succeeded" : "failed")
+                 << " due to DeleteFileRecursive.";
+    return r;
   }
   DWORD attr = GetFileAttributes(path.value().c_str());
   // We're done if we can't find the path.
-  if (attr == INVALID_FILE_ATTRIBUTES)
+  if (attr == INVALID_FILE_ATTRIBUTES) {
+    LOG(WARNING) << "base::DeleteFile: Succeeded because doesn't exist.";
     return true;
+  }
   // We may need to clear the read-only bit.
   if ((attr & FILE_ATTRIBUTE_READONLY) &&
       !SetFileAttributes(path.value().c_str(),
                           attr & ~FILE_ATTRIBUTE_READONLY)) {
+    LOG(WARNING) << "base::DeleteFile: Failed because read only.";
     return false;
   }
   // Directories are handled differently if they're recursive.
-  if (!(attr & FILE_ATTRIBUTE_DIRECTORY))
-    return !!::DeleteFile(path.value().c_str());
+  if (!(attr & FILE_ATTRIBUTE_DIRECTORY)) {
+    bool r = !!::DeleteFile(path.value().c_str());
+    LOG(WARNING) << "base::DeleteFile: " << (r ? "succeeded" : "failed")
+                 << " due to ::DeleteFile.";
+    return r;
+  }
   // Handle a simple, single file delete.
-  if (!recursive || DeleteFileRecursive(path, L"*", true))
-    return !!RemoveDirectory(path.value().c_str());
+  if (!recursive || DeleteFileRecursive(path, L"*", true)) {
+    bool r = !!RemoveDirectory(path.value().c_str());
+    LOG(WARNING) << "base::DeleteFile: " << (r ? "succeeded" : "failed")
+                 << " due to RemoveDirectory.";
+    return r;
+  }
 
+  LOG(WARNING) << "base::DeleteFile: Failed because ???.";
   return false;
 }
 
 bool DeleteFileAfterReboot(const FilePath& path) {
   ThreadRestrictions::AssertIOAllowed();
 
   if (path.value().length() >= MAX_PATH)
     return false;
 
   return MoveFileEx(path.value().c_str(), NULL,
@@ skipping 731 matching lines @@
     // Like Move, this function is not transactional, so we just
     // leave the copied bits behind if deleting from_path fails.
     // If to_path exists previously then we have already overwritten
     // it by now, we don't get better off by deleting the new bits.
   }
   return false;
 }
 
 }  // namespace internal
 }  // namespace base