Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2854303005: Fixes issue 29539 with the workaround of initializing libnotify early by calling localtime_r in OS:… (Closed)

Created:
3 years, 7 months ago by siva
Modified:
3 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes issue 29539 with the workaround of initializing libnotify early by calling localtime_r in OS::InitOnce(). BUG=Fixes #29539 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/9b1412031b66f86d2739595d115107def42b736d

Patch Set 1 #

Patch Set 2 : assss #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M runtime/vm/os_macos.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
siva
3 years, 7 months ago (2017-05-03 23:10:32 UTC) #2
rmacnak
lgtm commit message s/BUG=29539/Fixes #29539 BUG=n creates a link to a Chromium bug
3 years, 7 months ago (2017-05-04 00:38:02 UTC) #3
siva
3 years, 7 months ago (2017-05-04 01:24:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9b1412031b66f86d2739595d115107def42b736d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698