Reduce binary size of Builtins::CallableFor

src/builtins/builtins.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins.h"
 #include "src/api.h"
 #include "src/assembler-inl.h"
 #include "src/builtins/builtins-descriptors.h"
 #include "src/callable.h"
 #include "src/isolate.h"
@@ skipping 115 matching lines @@
                  IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN)
 #undef TFJ_CASE
     default:
       UNREACHABLE();
       return 0;
   }
 }
 
 // static
 Callable Builtins::CallableFor(Isolate* isolate, Name name) {
+  Handle<Code> code(
+      reinterpret_cast<Code**>(isolate->builtins()->builtin_address(name)));
+  CallDescriptors::Key key;
   switch (name) {
-#define CASE(Name, ...)                                              \
-  case k##Name: {                                                    \
-    Handle<Code> code = isolate->builtins()->Name();                 \
-    auto descriptor = Builtin_##Name##_InterfaceDescriptor(isolate); \
-    return Callable(code, descriptor);                               \
+// This macro is deliberately crafted so as to emit very little code,
+// in order to keep binary size of this function under control.
+#define CASE(Name, ...)                                \
+  case k##Name: {                                      \
+    key = Builtin_##Name##_InterfaceDescriptor::key(); \
+    break;                                             \
   }
     BUILTIN_LIST(IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, CASE, CASE,
                  CASE, IGNORE_BUILTIN, IGNORE_BUILTIN)
 #undef CASE
     case kConsoleAssert: {
-      Handle<Code> code = isolate->builtins()->ConsoleAssert();
       return Callable(code, BuiltinDescriptor(isolate));
     }
     default:
       UNREACHABLE();
       return Callable(Handle<Code>::null(), VoidDescriptor(isolate));
   }
+  CallInterfaceDescriptor descriptor(isolate, key);
+  return Callable(code, descriptor);
 }
 
 // static
 const char* Builtins::name(int index) {
   switch (index) {
 #define CASE(Name, ...) \
   case k##Name:         \
     return #Name;
     BUILTIN_LIST_ALL(CASE)
 #undef CASE
@@ skipping 91 matching lines @@
   // TODO(jochen): Remove this.
   if (responsible_context.is_null()) {
     return true;
   }
   if (*responsible_context == target->context()) return true;
   return isolate->MayAccess(responsible_context, target_global_proxy);
 }
 
 }  // namespace internal
 }  // namespace v8