remoting/client/ios/keychain_wrapper.h - Issue 2854273002: [CRD iOS] Implementing save to keychain and user defaults for login info. Refactor remoting service.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/client/ios/keychain_wrapper.h

Issue 2854273002: [CRD iOS] Implementing save to keychain and user defaults for login info. Refactor remoting service. (Closed)

Patch Set: Cleanup on self review. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« remoting/client/ios/facade/remoting_service.mm ('K') | « remoting/client/ios/facade/remoting_service.mm ('k') | remoting/client/ios/keychain_wrapper.mm » ('j') | remoting/client/ios/keychain_wrapper.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef REMOTING_CLIENT_IOS_KEYCHAIN_WRAPPER_H_

	6 #define REMOTING_CLIENT_IOS_KEYCHAIN_WRAPPER_H_

	7

	8 #import <Foundation/Foundation.h>

	9

	10 @class UserInfo;

	11

	12 // Class to abstract the details from how iOS wants to write to the keychain.

	13 // TODO(nicholss): This will have to be futher refactored when we integrate

	14 // with the private Google auth.

	15 @interface KeychainWrapper : NSObject

	16

	17 // Save a refresh token to the keychain.

	18 - (void)setRefreshToken:(NSString*)refreshToken;
	Yuwei 2017/05/04 05:10:15 What about using @property? What about using @property? nicholss 2017/05/08 17:08:10 In this case I think it is not good to use @proper Show quoted text On 2017/05/04 05:10:15, Yuwei wrote: > What about using @property? In this case I think it is not good to use @property because of the fact this is a wrapper and I am not 100% happy about this API, and I need it to be interchangeable with Chrome/Chromium version of this concept. This will have to be refactored when the integration with SSO happens but I am not 100% sure what that needs to look like yet so I want to hold off refactoring this until I can understand the SSO side of things a bit better. Yuwei 2017/05/08 19:00:58 Acknowledged. Show quoted text On 2017/05/08 17:08:10, nicholss wrote: > On 2017/05/04 05:10:15, Yuwei wrote: > > What about using @property? > > In this case I think it is not good to use @property because of the fact this is > a wrapper and I am not 100% happy about this API, and I need it to be > interchangeable with Chrome/Chromium version of this concept. This will have to > be refactored when the integration with SSO happens but I am not 100% sure what > that needs to look like yet so I want to hold off refactoring this until I can > understand the SSO side of things a bit better. Acknowledged.
	19 // Get the refresh token from the keychain, if there is one.

	20 - (NSString*)refreshToken;

	21 // Reset the keychain and the cache.

	22 - (void)resetKeychainItem;

	23

	24 @end

	25

	26 #endif // REMOTING_CLIENT_IOS_KEYCHAIN_WRAPPER_H_

OLD	NEW