[CRD iOS] Implementing save to keychain and user defaults for login info. Refactor remoting service.

remoting/client/ios/app/remoting_view_controller.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 #import "remoting/client/ios/app/remoting_view_controller.h"
 
 #import "base/mac/bind_objc_block.h"
 #import "ios/third_party/material_components_ios/src/components/AnimationTiming/src/MaterialAnimationTiming.h"
 #import "ios/third_party/material_components_ios/src/components/AppBar/src/MaterialAppBar.h"
 #import "ios/third_party/material_components_ios/src/components/Dialogs/src/MaterialDialogs.h"
 #import "ios/third_party/material_components_ios/src/components/Snackbar/src/MaterialSnackbar.h"
 #import "remoting/client/ios/app/client_connection_view_controller.h"
 #import "remoting/client/ios/app/host_collection_view_controller.h"
 #import "remoting/client/ios/app/host_view_controller.h"
 #import "remoting/client/ios/app/remoting_settings_view_controller.h"
 #import "remoting/client/ios/domain/client_session_details.h"
+#import "remoting/client/ios/facade/remoting_authentication.h"
 #import "remoting/client/ios/facade/remoting_service.h"
 #import "remoting/client/ios/session/remoting_client.h"
 
 #include "base/strings/sys_string_conversions.h"
 #include "remoting/base/oauth_token_getter.h"
 #include "remoting/client/connect_to_host_info.h"
 
 static CGFloat kHostInset = 5.f;
 
 @interface RemotingViewController ()<HostCollectionViewControllerDelegate,
@@ skipping 21 matching lines @@
       [[UICollectionViewFlowLayout alloc] init];
   layout.minimumInteritemSpacing = 0;
   CGFloat sectionInset = kHostInset * 2.f;
   [layout setSectionInset:UIEdgeInsetsMake(sectionInset, sectionInset,
                                            sectionInset, sectionInset)];
   HostCollectionViewController* collectionVC = [
       [HostCollectionViewController alloc] initWithCollectionViewLayout:layout];
   self = [super initWithContentViewController:collectionVC];
   if (self) {
     _remotingService = [RemotingService SharedInstance];
-    [_remotingService setAuthenticationDelegate:self];
 
     _collectionViewController = collectionVC;
     _collectionViewController.flexHeaderContainerViewController = self;
     _collectionViewController.delegate = self;
 
     _appBar = [[MDCAppBar alloc] init];
     [self addChildViewController:_appBar.headerViewController];
 
     _appBar.headerViewController.headerView.backgroundColor =
         [UIColor clearColor];
@@ skipping 20 matching lines @@
              object:nil];
   }
   return self;
 }
 
 #pragma mark - UIViewController
 
 - (void)viewDidLoad {
   [super viewDidLoad];
   [_appBar addSubviewsToParent];
+
+  [[NSNotificationCenter defaultCenter]
+      addObserver:self
+         selector:@selector(hostsDidUpdateNotification:)
+             name:kHostsDidUpdate
+           object:nil];
+  [[NSNotificationCenter defaultCenter]
+      addObserver:self
+         selector:@selector(userDidUpdateNotification:)
+             name:kUserDidUpdate
+           object:nil];
+}
+
+- (void)viewWillAppear:(BOOL)animated {
+  [super viewWillAppear:animated];
+
+  [self nowAuthenticated:_remotingService.authentication.user.isAuthenticated];
   [self presentStatus];
 }
 
 - (void)viewDidAppear:(BOOL)animated {
+  [super viewDidAppear:animated];
   if (!_isAuthenticated) {
     // TODO(nicholss): This is used as a demo of the app functionality for the
     // moment but the real app will force the login flow if unauthenticated.
     [self didSelectSettings];
     // [self didSelectRefresh];
     MDCSnackbarMessage* message = [[MDCSnackbarMessage alloc] init];
     message.text = @"Please login.";
     [MDCSnackbarManager showMessage:message];
+  } else {
+    [_remotingService requestHostListFetch];
   }
 }
 
 - (void)viewDidLayoutSubviews {
   [super viewDidLayoutSubviews];
 
   // Adjust the collection view's position and size so that it doesn't get
   // overlayed by the navigation bar.
   CGFloat collectionOffsetY =
       _appBar.headerViewController.headerView.frame.size.height;
   CGFloat collectionHeight = self.view.bounds.size.height - collectionOffsetY;
   CGRect oldFrame = _collectionViewController.collectionView.frame;
   _collectionViewController.collectionView.frame =
       CGRectMake(oldFrame.origin.x, collectionOffsetY, oldFrame.size.width,
                  collectionHeight);
 }
 
+#pragma mark - Remoting Service Notifications
+
+- (void)hostsDidUpdateNotification:(NSNotification*)notification {
+  [_collectionViewController.collectionView reloadData];
+}
+
+- (void)userDidUpdateNotification:(NSNotification*)notification {
+  [self nowAuthenticated:_remotingService.authentication.user.isAuthenticated];
+}
+
 #pragma mark - RemotingAuthenticationDelegate
 
 - (void)nowAuthenticated:(BOOL)authenticated {
   if (authenticated) {
     MDCSnackbarMessage* message = [[MDCSnackbarMessage alloc] init];
     message.text = @"Logged In!";
     [MDCSnackbarManager showMessage:message];
-    [_remotingService setHostListDelegate:self];
   } else {
     MDCSnackbarMessage* message = [[MDCSnackbarMessage alloc] init];
     message.text = @"Not logged in.";
     [MDCSnackbarManager showMessage:message];
-    [_remotingService setHostListDelegate:nil];
   }
   _isAuthenticated = authenticated;
   [_collectionViewController.collectionView reloadData];
 }
 
 #pragma mark - RemotingHostListDelegate
 
 // TODO(nicholss): these need to be a stats change like "none, loading,
 // updated"...
 - (void)hostListUpdated {
@@ skipping 14 matching lines @@
   }
   return nil;
 }
 
 #pragma mark - HostCollectionViewControllerDelegate
 
 - (void)didSelectCell:(HostCollectionViewCell*)cell
            completion:(void (^)())completionBlock {
   _client = [[RemotingClient alloc] init];
 
-  [_remotingService
+  [_remotingService.authentication
       callbackWithAccessToken:base::BindBlockArc(^(
                                   remoting::OAuthTokenGetter::Status status,
                                   const std::string& user_email,
                                   const std::string& access_token) {
         // TODO(nicholss): Check status.
         HostInfo* hostInfo = cell.hostInfo;
         [_client connectToHost:hostInfo
                       username:base::SysUTF8ToNSString(user_email)
                    accessToken:base::SysUTF8ToNSString(access_token)];
       })];
 
   ClientConnectionViewController* clientConnectionViewController =
       [[ClientConnectionViewController alloc] init];
   clientConnectionViewController.delegate = self;
   [self presentViewController:clientConnectionViewController
                      animated:YES
                    completion:nil];
   completionBlock();
 }
 
 - (NSInteger)getHostCount {
-  NSArray<HostInfo*>* hosts = [_remotingService getHosts];
-  return [hosts count];
+  return _remotingService.hosts.count;
 }
 
 - (HostInfo*)getHostAtIndexPath:(NSIndexPath*)path {
-  NSArray<HostInfo*>* hosts = [_remotingService getHosts];
-  return hosts[path.row];
+  return _remotingService.hosts[path.row];
 }
 
 #pragma mark - UIViewControllerTransitioningDelegate
 
 - (nullable id<UIViewControllerAnimatedTransitioning>)
 animationControllerForPresentedController:(UIViewController*)presented
                      presentingController:(UIViewController*)presenting
                          sourceController:(UIViewController*)source {
   // TODO(nicholss): Not implemented yet.
   return nil;
@@ skipping 19 matching lines @@
 
 - (void)hostSessionStatusChanged:(NSNotification*)notification {
   NSLog(@"hostSessionStatusChanged: %@", [notification userInfo]);
 }
 
 - (void)closeViewController {
   [self dismissViewControllerAnimated:true completion:nil];
 }
 
 - (void)didSelectRefresh {
-  // TODO(nicholss) implement this.
-  NSLog(@"Should refresh...");
-  _dialogTransitionController = [[MDCDialogTransitionController alloc] init];
+  // TODO(nicholss): Might want to rate limit this. Maybe remoting service
+  // controls that.
+  [_remotingService requestHostListFetch];
 }
 
 - (void)didSelectSettings {
   RemotingSettingsViewController* settingsViewController =
       [[RemotingSettingsViewController alloc] init];
   [self presentViewController:settingsViewController
                      animated:YES
                    completion:nil];
 }
 
 - (void)presentStatus {
   MDCSnackbarMessage* message = [[MDCSnackbarMessage alloc] init];
   if (_isAuthenticated) {
-    UserInfo* user = [_remotingService getUser];
-    message.text = [NSString
-        stringWithFormat:@"Currently signed in as %@.", [user userEmail]];
+    message.text = [NSString stringWithFormat:@"Currently signed in as %@.",
+                                              _remotingService.user.userEmail];
     [MDCSnackbarManager showMessage:message];
   }
 }
 
 @end