components/security_interstitials/core/browser/resources/interstitial_webview_quiet.html - Issue 2854263003: Add quiet safe browsing interstitial for WebView

Unified Diff: components/security_interstitials/core/browser/resources/interstitial_webview_quiet.html

Issue 2854263003: Add quiet safe browsing interstitial for WebView (Closed)

Patch Set: Updates to the HTML / CSS Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« components/security_interstitials/core/browser/resources/interstitial_webview_quiet.css ('K') | « components/security_interstitials/core/browser/resources/interstitial_webview_quiet.css ('k') | components/security_interstitials/core/safe_browsing_quiet_error_ui.h » ('j') | components/security_interstitials/core/safe_browsing_quiet_error_ui.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/security_interstitials/core/browser/resources/interstitial_webview_quiet.html

diff --git a/components/security_interstitials/core/browser/resources/interstitial_webview_quiet.html b/components/security_interstitials/core/browser/resources/interstitial_webview_quiet.html

new file mode 100644

index 0000000000000000000000000000000000000000..83c605dd7f810ae65e7d4cea0d19a2c7bae2f900

--- /dev/null

+++ b/components/security_interstitials/core/browser/resources/interstitial_webview_quiet.html

@@ -0,0 +1,28 @@

+<!doctype html>

+<html i18n-values="dir:textdirection;lang:language">

Dan Beam 2017/05/08 17:58:04 can we use dir="$i18n{textdirection}" lang="$i18n{

edwardjung 2017/05/08 23:21:11 Nice suggestion. I didn't know about this. Much mo

+<head>

+ <meta charset="utf-8">

+ <meta name="viewport"

+ content="initial-scale=1, minimum-scale=1, width=device-width">

+ <title i18n-content="tabTitle"></title>

+ <link rel="stylesheet" href="interstitial_common.css">

+ <link rel="stylesheet" href="interstitial_webview_quiet.css">

+ <script src="../../../../../ui/webui/resources/js/util.js"></script>

+</head>

+<body id="body" jsvalues=".className:is_giant ? 'giant' : ''">

+ <div class="interstitial-wrapper">

+ <div id="main-content">

+ <div class="icon"></div>

+ <div id="main-message">

+ <h1>

+ <span i18n-content="heading"></span>

Dan Beam 2017/05/08 17:58:04 <span>$i18n{heading}</span>

edwardjung 2017/05/08 23:21:11 Done.

+ <a id="details-link" i18n-content="openDetails"></a>

+ </h1>

+ </div>

+ <div id="details" class="hidden">

+ <p i18n-values=".innerHTML:explanationParagraph"></p>

Dan Beam 2017/05/08 17:58:04 why does this need to be innerHTML? it is insecur

edwardjung 2017/05/08 23:21:11 Understand that innerHTML is evil. However the str

Dan Beam 2017/05/16 03:37:30 see also: $i18nRaw{}

+ </div>

+</body>

+</html>