components/security_interstitials/core/safe_browsing_loud_error_ui.cc - Issue 2854263003: Add quiet safe browsing interstitial for WebView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/security_interstitials/core/safe_browsing_loud_error_ui.cc

Issue 2854263003: Add quiet safe browsing interstitial for WebView (Closed)

Patch Set: Fix unit test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/security_interstitials/core/safe_browsing_loud_error_ui.h ('k') | components/security_interstitials/core/safe_browsing_quiet_error_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/security_interstitials/core/safe_browsing_loud_error_ui.cc

diff --git a/components/security_interstitials/core/safe_browsing_loud_error_ui.cc b/components/security_interstitials/core/safe_browsing_loud_error_ui.cc

index 8c0df9ab2f270fbb33326a865658ddcaf4c74b43..96207898d02a3eb14fec0a732c8256b7f4aae7cd 100644

--- a/components/security_interstitials/core/safe_browsing_loud_error_ui.cc

+++ b/components/security_interstitials/core/safe_browsing_loud_error_ui.cc

@@ -78,7 +78,7 @@ SafeBrowsingLoudErrorUI::~SafeBrowsingLoudErrorUI() {

controller()->metrics_helper()->RecordShutdownMetrics();

}

-void SafeBrowsingLoudErrorUI::PopulateStringsForHTML(

+void SafeBrowsingLoudErrorUI::PopulateStringsForHtml(

base::DictionaryValue* load_time_data) {

DCHECK(load_time_data);