components/security_interstitials_strings.grdp - Issue 2854263003: Add quiet safe browsing interstitial for WebView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/security_interstitials_strings.grdp

Issue 2854263003: Add quiet safe browsing interstitial for WebView (Closed)

Patch Set: Remove old safe_browsing_prefs.h include from test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/security_interstitials/core/safe_browsing_quiet_error_ui.cc ('K') | « components/security_interstitials/core/safe_browsing_quiet_error_ui.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/security_interstitials_strings.grdp

diff --git a/components/security_interstitials_strings.grdp b/components/security_interstitials_strings.grdp

index 51b64d827cec32b6ece4dcf8c9385a69c4aa9788..2619452108b2ef011b9fda8f0f9fc0d9e4a28d4c 100644

--- a/components/security_interstitials_strings.grdp

+++ b/components/security_interstitials_strings.grdp

@@ -186,4 +186,21 @@

You can <ph name="BEGIN_ERROR_LINK"><a href="#" id="report-error-link"></ph>report a detection problem<ph name="END_ERROR_LINK"></a></ph> or, if you understand the risks to your security, <ph name="BEGIN_LINK"><a href="#" id="proceed-link"></ph>visit this unsafe site<ph name="END_LINK"></a></ph>.

</message>

+

+ <message name="IDS_MALWARE_WEBVIEW_HEADING" desc="The heading of the malware interstitial on medium sized Webview.">

+ Dangerous content blocked

+ </message>

+ <message name="IDS_MALWARE_WEBVIEW_EXPLANATION_PARAGRAPH" desc="The explanation of why Safe Browsing has blocked the page. Allows the user to proceed using a link.">

felt 2017/05/17 16:33:26 does this allow the user to proceed using a link?

edwardjung 2017/05/17 22:49:33 Good spot, this string was refactored. But actuall

+ This content might try to install dangerous software on your device that steals or deletes your information.

+ </message>

+ <message name="IDS_PHISHING_WEBVIEW_HEADING" desc="The heading of the phishing interstitial on medium sized Webview.">

+ Deceptive content blocked

+ </message>

+ <message name="IDS_PHISHING_WEBVIEW_EXPLANATION_PARAGRAPH" desc="The explanation of why Safe Browsing has blocked the page. Allows the user to proceed using a link.">

+ This content might try to trick you into installing software or revealing personal information.

+ </message>

+ <message name="IDS_WEBVIEW_PROCEED_LINK" desc="The text of the link that allows the user to proceed.">

+ Show anyway

+ </message>

</grit-part>