Omnibox UI Experiments: Add vertical margin variations to about:flags

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 913 matching lines @@
 const FeatureEntry::Choice kEnableHeapProfilingChoices[] = {
     {flags_ui::kGenericExperimentChoiceDisabled, "", ""},
     {flag_descriptions::kEnableHeapProfilingModePseudo,
      switches::kEnableHeapProfiling, switches::kEnableHeapProfilingModePseudo},
     {flag_descriptions::kEnableHeapProfilingModeNative,
      switches::kEnableHeapProfiling, switches::kEnableHeapProfilingModeNative},
     {flag_descriptions::kEnableHeapProfilingTaskProfiler,
      switches::kEnableHeapProfiling,
      switches::kEnableHeapProfilingTaskProfiler}};
 
+const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin4px[] = {
+    {OmniboxFieldTrial::kUIExperimentsVerticalMarginParam, "4"}};
+const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin8px[] = {
+    {OmniboxFieldTrial::kUIExperimentsVerticalMarginParam, "8"}};
+const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin12px[] = {
+    {OmniboxFieldTrial::kUIExperimentsVerticalMarginParam, "12"}};
+const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin16px[] = {
+    {OmniboxFieldTrial::kUIExperimentsVerticalMarginParam, "16"}};
+const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin20px[] = {
+    {OmniboxFieldTrial::kUIExperimentsVerticalMarginParam, "20"}};
+
+const FeatureEntry::FeatureVariation kOmniboxUIVerticalMarginVariations[] = {
+    {"4px vertical margin", kOmniboxUIVerticalMargin4px,
+     arraysize(kOmniboxUIVerticalMargin4px), nullptr},
+    {"8px vertical margin", kOmniboxUIVerticalMargin8px,
+     arraysize(kOmniboxUIVerticalMargin8px), nullptr},
+    {"12px vertical margin", kOmniboxUIVerticalMargin12px,
+     arraysize(kOmniboxUIVerticalMargin12px), nullptr},
+    {"16px vertical margin", kOmniboxUIVerticalMargin16px,
+     arraysize(kOmniboxUIVerticalMargin16px), nullptr},
+    {"20px vertical margin", kOmniboxUIVerticalMargin20px,
+     arraysize(kOmniboxUIVerticalMargin20px), nullptr}};
+
 // RECORDING USER METRICS FOR FLAGS:
 // -----------------------------------------------------------------------------
 // The first line of the entry is the internal name.
 //
 // To add a new entry, add to the end of kFeatureEntries. There are two
 // distinct types of entries:
 // . SINGLE_VALUE: entry is either on or off. Use the SINGLE_VALUE_TYPE
 //   macro for this type supplying the command line to the macro.
 // . MULTI_VALUE: a list of choices, the first of which should correspond to a
 //   deactivated state for this lab (i.e. no command line option).  To specify
@@ skipping 1792 matching lines @@
     {"enable-copyless-paste", flag_descriptions::kEnableCopylessPasteName,
      flag_descriptions::kEnableCopylessPasteDescription, kOsAndroid,
      FEATURE_VALUE_TYPE(features::kCopylessPaste)},
 #endif
 
     {"omnibox-display-title-for-current-url",
      flag_descriptions::kOmniboxDisplayTitleForCurrentUrlName,
      flag_descriptions::kOmniboxDisplayTitleForCurrentUrlDescription,
      kOsDesktop, FEATURE_VALUE_TYPE(omnibox::kDisplayTitleForCurrentUrl)},
 
+    {"omnibox-ui-vertical-margin",

[Mark P, 2017/05/03 18:38:59]

nit: We're supposed to put new entries at the end.
(Frankly, I don't care.)

[tommycli, 2017/05/03 18:49:46]

Done.

+     flag_descriptions::kOmniboxUIVerticalMarginName,
+     flag_descriptions::kOmniboxUIVerticalMarginDescription, kOsDesktop,
+     FEATURE_WITH_PARAMS_VALUE_TYPE(omnibox::kUIExperiments,
+                                    kOmniboxUIVerticalMarginVariations,
+                                    "OmniboxUIVerticalMarginVariations")},
+
     {"enable-color-correct-rendering",
      flag_descriptions::kColorCorrectRenderingName,
      flag_descriptions::kColorCorrectRenderingDescription, kOsAll,
      MULTI_VALUE_TYPE(kColorCorrectRenderingChoices)},
 
 #if defined(OS_CHROMEOS)
     {"quick-unlock-pin-signin", flag_descriptions::kQuickUnlockPinSignin,
      flag_descriptions::kQuickUnlockPinSigninDescription, kOsCrOS,
      FEATURE_VALUE_TYPE(features::kQuickUnlockPinSignin)},
 #endif  // OS_CHROMEOS
@@ skipping 248 matching lines @@
 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
 
 const FeatureEntry* GetFeatureEntries(size_t* count) {
   *count = arraysize(kFeatureEntries);
   return kFeatureEntries;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags