Moves translate snackbar functionality to Android side.

chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.infobar;
 
 import android.support.design.widget.TabLayout;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.View.OnClickListener;
 import android.widget.LinearLayout;
 
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.infobar.translate.TranslateMenu;
 import org.chromium.chrome.browser.infobar.translate.TranslateMenuHelper;
 import org.chromium.chrome.browser.infobar.translate.TranslateTabLayout;
 import org.chromium.chrome.browser.snackbar.Snackbar;
+import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;
 import org.chromium.chrome.browser.widget.TintedImageButton;
 import org.chromium.ui.widget.Toast;
 
 /**
  * Java version of the compcat translate infobar
  */
 class TranslateCompactInfoBar extends InfoBar
         implements TabLayout.OnTabSelectedListener, TranslateMenuHelper.TranslateMenuListener {
     public static final int TRANSLATING_INFOBAR = 1;
 
     private static final int SOURCE_TAB_INDEX = 0;
     private static final int TARGET_TAB_INDEX = 1;
 
     private final int mInitialStep;
     private final TranslateOptions mOptions;
 
     private long mNativeTranslateInfoBarPtr;
     private TranslateTabLayout mTabLayout;
 
     // Need 2 instances of TranslateMenuHelper to prevent a race condition bug which happens when
     // showing language menu after dismissing overflow menu.
     private TranslateMenuHelper mOverflowMenuHelper;
     private TranslateMenuHelper mLanguageMenuHelper;
 
     private TintedImageButton mMenuButton;
 
+    enum TranslateSnackbarType { NONE, ALWAYS_TRANSLATE, NEVER_TRANSLATE, NEVER_TRANSLATE_SITE }
+    ;

[gone, 2017/05/04 17:20:52]

1) git cl format?  This ; on its own line is weird.

2) Don't use enums; they're bloated in Java.  Define private static final ints
like here:

https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...

[ramyasharma, 2017/05/05 02:55:13]

Yes, git cl format put that ";" on the next line :-/. 
Getting rid of the enum. thanks.

+
+    class TranslateSnackbarController implements SnackbarController {

[gone, 2017/05/04 17:20:52]

javadoc

[ramyasharma, 2017/05/05 02:55:13]

done.

+        private TranslateSnackbarType mSnackbarType;

[gone, 2017/05/04 17:20:52]

final

[ramyasharma, 2017/05/05 02:55:13]

Done.

+
+        public TranslateSnackbarController(TranslateSnackbarType snackbarType) {
+            this.snackbarType = snackbarType;

[gone, 2017/05/04 17:20:52]

Does this compile?

[ramyasharma, 2017/05/05 02:55:13]

argh.. sorry. No it doesn't. I missed updating other places. Have made some more
changes. Not defining my constants for snackbar type, instead using the existing
menu item.

+        }
+
+        @Override
+        public void onDismissNoAction(Object actionData) {
+            switch (snackbarType) {
+                case ALWAYS_TRANSLATE:
+                    nativeApplyBoolTranslateOption(
+                            mNativeTranslateInfoBarPtr, TranslateOption.ALWAYS_TRANSLATE, true);
+                    return;
+                case NEVER_TRANSLATE:
+                    nativeApplyBoolTranslateOption(
+                            mNativeTranslateInfoBarPtr, TranslateOption.NEVER_TRANSLATE, true);
+                    return;
+                case NEVER_TRANSLATE_SITE:
+                    nativeApplyBoolTranslateOption(
+                            mNativeTranslateInfoBarPtr, TranslateOption.NEVER_TRANSLATE_SITE, true);
+                    return;
+            }
+        }
+
+        @Override
+        public void onAction(Object actionData) {
+            // do nothing.
+        }
+    };
+
     @CalledByNative
     private static InfoBar create(int initialStep, String sourceLanguageCode,
             String targetLanguageCode, boolean alwaysTranslate, boolean triggeredFromMenu,
             String[] languages, String[] codes) {
         return new TranslateCompactInfoBar(initialStep, sourceLanguageCode, targetLanguageCode,
                 alwaysTranslate, triggeredFromMenu, languages, codes);
     }
 
     TranslateCompactInfoBar(int initialStep, String sourceLanguageCode, String targetLanguageCode,
             boolean alwaysTranslate, boolean triggeredFromMenu, String[] languages,
@@ skipping 116 matching lines @@
     public void onTabReselected(TabLayout.Tab tab) {}
 
     @Override
     public void onOverflowMenuItemClicked(int itemId) {
         switch (itemId) {
             case TranslateMenu.ID_OVERFLOW_MORE_LANGUAGE:
                 initMenuHelper(TranslateMenu.MENU_TARGET_LANGUAGE);
                 mLanguageMenuHelper.show(TranslateMenu.MENU_TARGET_LANGUAGE);
                 return;
             case TranslateMenu.ID_OVERFLOW_ALWAYS_TRANSLATE:
-                nativeApplyBoolTranslateOption(
-                        mNativeTranslateInfoBarPtr, TranslateOption.ALWAYS_TRANSLATE, true);
                 showSnackbar(TranslateSnackbarType.ALWAYS_TRANSLATE);
                 return;
             case TranslateMenu.ID_OVERFLOW_NEVER_LANGUAGE:
-                nativeApplyBoolTranslateOption(
-                        mNativeTranslateInfoBarPtr, TranslateOption.NEVER_TRANSLATE, true);
                 showSnackbar(TranslateSnackbarType.NEVER_TRANSLATE);
                 return;
             case TranslateMenu.ID_OVERFLOW_NEVER_SITE:
-                nativeApplyBoolTranslateOption(
-                        mNativeTranslateInfoBarPtr, TranslateOption.NEVER_TRANSLATE_SITE, true);
                 showSnackbar(TranslateSnackbarType.NEVER_TRANSLATE_SITE);
                 return;
             case TranslateMenu.ID_OVERFLOW_NOT_THIS_LANGUAGE:
                 initMenuHelper(TranslateMenu.MENU_SOURCE_LANGUAGE);
                 mLanguageMenuHelper.show(TranslateMenu.MENU_SOURCE_LANGUAGE);
                 return;
             default:
                 assert false : "Unexpected overflow menu code";
         }
     }
@@ skipping 15 matching lines @@
         // Reset source code in both UI and native.
         if (mOptions.setSourceLanguage(code)) {
             nativeApplyStringTranslateOption(
                     mNativeTranslateInfoBarPtr, TranslateOption.SOURCE_CODE, code);
             // Adjust UI.
             mTabLayout.replaceTabTitle(SOURCE_TAB_INDEX, mOptions.getRepresentationFromCode(code));
             startTranslating(mTabLayout.getSelectedTabPosition());
         }
     }
 
-    private void showSnackbar(int snackbarType) {
+    private void showSnackbar(TranslateSnackbarType snackbarType) {
         if (snackbarType == TranslateSnackbarType.NEVER_TRANSLATE) {
             createAndShowSnackbar(getContext().getString(R.string.translate_snackbar_language_never,
                                           mOptions.sourceLanguageName()),
-                    Snackbar.UMA_TRANSLATE_NEVER);
+                    Snackbar.UMA_TRANSLATE_NEVER, snackbarType);
         } else if (snackbarType == TranslateSnackbarType.ALWAYS_TRANSLATE) {
             createAndShowSnackbar(
                     getContext().getString(R.string.translate_snackbar_always_translate,
                             mOptions.sourceLanguageName(), mOptions.targetLanguageName()),
-                    Snackbar.UMA_TRANSLATE_ALWAYS);
+                    Snackbar.UMA_TRANSLATE_ALWAYS, snackbarType);
         } else if (snackbarType == TranslateSnackbarType.NEVER_TRANSLATE_SITE) {
             createAndShowSnackbar(getContext().getString(R.string.translate_snackbar_site_never),
-                    Snackbar.UMA_TRANSLATE_NEVER_SITE);
+                    Snackbar.UMA_TRANSLATE_NEVER_SITE, snackbarType);
         }
     }
 
-    private void createAndShowSnackbar(String title, int type) {
+    private void createAndShowSnackbar(String title, int type, TranslateSnackbarType snackbarType) {
         if (getSnackbarManager() == null) {
             return;
         }
-        getSnackbarManager().showSnackbar(Snackbar.make(title, new TranslateSnackbarController(),
-                                                          Snackbar.TYPE_NOTIFICATION, type)
-                                                  .setSingleLine(false));
+        getSnackbarManager().showSnackbar(
+                Snackbar.make(title, new TranslateSnackbarController(snackbarType),
+                                Snackbar.TYPE_NOTIFICATION, type)
+                        .setSingleLine(false)
+                        .setAction(
+                                getContext().getString(R.string.translate_snackbar_cancel), null));
     }
 
     private native void nativeApplyStringTranslateOption(
             long nativeTranslateCompactInfoBar, int option, String value);
     private native void nativeApplyBoolTranslateOption(
             long nativeTranslateCompactInfoBar, int option, boolean value);
 }