Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

Issue 2854213004: Update layer size from LayoutBox::UpdateAfterLayout (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
index 17b6bb2da6f5be29cf3b3e85886f294edabcc5a1..941ddcddb20ce617eb3f2803d44d115e88666c2c 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
@@ -655,11 +655,13 @@ void LayoutBlockFlow::DetermineLogicalLeftPositionForChild(LayoutBox& child) {
void LayoutBlockFlow::SetLogicalLeftForChild(LayoutBox& child,
LayoutUnit logical_left) {
+ LayoutPoint new_location(child.Location());
if (IsHorizontalWritingMode()) {
- child.SetX(logical_left);
+ new_location.SetX(logical_left);
} else {
- child.SetY(logical_left);
+ new_location.SetY(logical_left);
}
+ child.SetLocationAndUpdateOverflowControlsIfNeeded(new_location);
bokan 2017/05/12 15:58:17 Should we not do this for the SetLogicalTopForChil
szager1 2017/05/12 19:12:12 No, because SetLogicalTopForChild is called *befor
}
void LayoutBlockFlow::SetLogicalTopForChild(LayoutBox& child,

Powered by Google App Engine
This is Rietveld 408576698