Issue 2854183005: js_externs_generator: Treat empty object as Object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2854183005: js_externs_generator: Treat empty object as Object

Created:
3 years, 7 months ago by michaelpg

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

js_externs_generator: Treat empty object as Object Breaks IDL tests, may not be the right approach BUG=717827 COMMIT=false

Patch Set 1 #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	tools/json_schema_compiler/js_externs_generator.py	View		1 chunk	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

michaelpg

3 years, 7 months ago (2017-05-03 03:06:52 UTC) #1

This fails FAIL: JsExternGeneratorTest in testBasic:

  /**
   * A map from string to number.
   * @type {Object<string, number>}
+  * @typedef {Object}
   * @see https://developer.chrome.com/extensions/fakeApi#type-dict
   */
  chrome.fakeApi.Qux.prototype.dict;

where a plain Object<string, foo> property of a dictionary in an IDL file is
inadvertently be affected by the change to _AppendTypedef.

Expand Messages | Collapse Messages