Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: cc/surfaces/display_scheduler.h

Issue 2854163003: [cc] Plumb BeginFrameAcks through SurfaceManager to DisplayScheduler. (Closed)
Patch Set: track state in DisplayScheduler rather than Surface Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_SURFACES_DISPLAY_SCHEDULER_H_ 5 #ifndef CC_SURFACES_DISPLAY_SCHEDULER_H_
6 #define CC_SURFACES_DISPLAY_SCHEDULER_H_ 6 #define CC_SURFACES_DISPLAY_SCHEDULER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/cancelable_callback.h" 10 #include "base/cancelable_callback.h"
11 #include "base/containers/flat_map.h"
11 #include "base/macros.h" 12 #include "base/macros.h"
12 #include "base/memory/ref_counted.h" 13 #include "base/memory/ref_counted.h"
13 #include "base/single_thread_task_runner.h" 14 #include "base/single_thread_task_runner.h"
14 #include "cc/output/renderer_settings.h" 15 #include "cc/output/renderer_settings.h"
15 #include "cc/scheduler/begin_frame_source.h" 16 #include "cc/scheduler/begin_frame_source.h"
17 #include "cc/surfaces/surface_aggregator.h"
16 #include "cc/surfaces/surface_id.h" 18 #include "cc/surfaces/surface_id.h"
17 #include "cc/surfaces/surfaces_export.h" 19 #include "cc/surfaces/surfaces_export.h"
18 20
19 namespace cc { 21 namespace cc {
20 22
21 class BeginFrameSource; 23 class BeginFrameSource;
24 class SurfaceInfo;
25 class SurfaceManager;
22 26
23 class CC_SURFACES_EXPORT DisplaySchedulerClient { 27 class CC_SURFACES_EXPORT DisplaySchedulerClient {
24 public: 28 public:
25 virtual ~DisplaySchedulerClient() {} 29 virtual ~DisplaySchedulerClient() {}
26 30
27 virtual bool DrawAndSwap() = 0; 31 virtual bool DrawAndSwap() = 0;
32 virtual const SurfaceAggregator::SurfaceIndexMap&
33 GetPreviousContainedSurfaces() = 0;
28 }; 34 };
29 35
30 class CC_SURFACES_EXPORT DisplayScheduler : public BeginFrameObserverBase { 36 class CC_SURFACES_EXPORT DisplayScheduler : public BeginFrameObserverBase {
31 public: 37 public:
32 DisplayScheduler(base::SingleThreadTaskRunner* task_runner, 38 DisplayScheduler(base::SingleThreadTaskRunner* task_runner,
33 int max_pending_swaps); 39 int max_pending_swaps);
34 ~DisplayScheduler() override; 40 ~DisplayScheduler() override;
35 41
36 void SetClient(DisplaySchedulerClient* client); 42 void SetClient(DisplaySchedulerClient* client);
37 void SetBeginFrameSource(BeginFrameSource* begin_frame_source); 43 void SetBeginFrameSource(BeginFrameSource* begin_frame_source);
44 void SetSurfaceManager(SurfaceManager* surface_manager);
38 45
39 void SetVisible(bool visible); 46 void SetVisible(bool visible);
40 void SetRootSurfaceResourcesLocked(bool locked); 47 void SetRootSurfaceResourcesLocked(bool locked);
41 void ForceImmediateSwapIfPossible(); 48 void ForceImmediateSwapIfPossible();
42 virtual void DisplayResized(); 49 virtual void DisplayResized();
43 virtual void SetNewRootSurface(const SurfaceId& root_surface_id); 50 virtual void SetNewRootSurface(const SurfaceId& root_surface_id);
44 virtual void SurfaceDamaged(const SurfaceId& surface_id); 51 virtual void SurfaceDamaged(const SurfaceId& surface_id);
52 void SurfaceCreated(const SurfaceInfo& surface_info);
53 void SurfaceDestroyed(const SurfaceId& surface_id);
54 void SurfaceReceivedBeginFrame(const SurfaceId& surface_id,
55 const BeginFrameArgs& args);
56 void SurfaceFinishedBeginFrame(const SurfaceId& surface_id,
57 const BeginFrameAck& ack);
45 58
46 virtual void DidSwapBuffers(); 59 virtual void DidSwapBuffers();
47 void DidReceiveSwapBuffersAck(); 60 void DidReceiveSwapBuffersAck();
48 61
49 void OutputSurfaceLost(); 62 void OutputSurfaceLost();
50 63
51 // BeginFrameObserverBase implementation 64 // BeginFrameObserverBase implementation
52 bool OnBeginFrameDerivedImpl(const BeginFrameArgs& args) override; 65 bool OnBeginFrameDerivedImpl(const BeginFrameArgs& args) override;
53 void OnBeginFrameSourcePausedChanged(bool paused) override; 66 void OnBeginFrameSourcePausedChanged(bool paused) override;
54 67
55 protected: 68 protected:
56 base::TimeTicks DesiredBeginFrameDeadlineTime(); 69 base::TimeTicks DesiredBeginFrameDeadlineTime();
57 virtual void ScheduleBeginFrameDeadline(); 70 virtual void ScheduleBeginFrameDeadline();
58 bool AttemptDrawAndSwap(); 71 bool AttemptDrawAndSwap();
59 void OnBeginFrameDeadline(); 72 void OnBeginFrameDeadline();
60 bool DrawAndSwap(); 73 bool DrawAndSwap();
61 void StartObservingBeginFrames(); 74 void StartObservingBeginFrames();
62 void StopObservingBeginFrames(); 75 void StopObservingBeginFrames();
63 bool ShouldDraw(); 76 bool ShouldDraw();
64 void DidFinishFrame(bool did_draw); 77 void DidFinishFrame(bool did_draw);
78 // Updates |has_pending_surfaces_| and returns whether its value changed.
79 bool UpdateHasPendingSurfaces(const SurfaceId& changed_surface_id);
65 80
66 DisplaySchedulerClient* client_; 81 DisplaySchedulerClient* client_;
67 BeginFrameSource* begin_frame_source_; 82 BeginFrameSource* begin_frame_source_;
83 SurfaceManager* surface_manager_;
68 base::SingleThreadTaskRunner* task_runner_; 84 base::SingleThreadTaskRunner* task_runner_;
69 85
70 BeginFrameArgs current_begin_frame_args_; 86 BeginFrameArgs current_begin_frame_args_;
71 base::Closure begin_frame_deadline_closure_; 87 base::Closure begin_frame_deadline_closure_;
72 base::CancelableClosure begin_frame_deadline_task_; 88 base::CancelableClosure begin_frame_deadline_task_;
73 base::TimeTicks begin_frame_deadline_task_time_; 89 base::TimeTicks begin_frame_deadline_task_time_;
74 90
75 base::CancelableClosure missed_begin_frame_task_; 91 base::CancelableClosure missed_begin_frame_task_;
76 bool inside_surface_damaged_; 92 bool inside_surface_damaged_;
77 93
78 bool visible_; 94 bool visible_;
79 bool output_surface_lost_; 95 bool output_surface_lost_;
80 bool root_surface_resources_locked_; 96 bool root_surface_resources_locked_;
81 97
82 bool inside_begin_frame_deadline_interval_; 98 bool inside_begin_frame_deadline_interval_;
83 bool needs_draw_; 99 bool needs_draw_;
84 bool expecting_root_surface_damage_because_of_resize_; 100 bool expecting_root_surface_damage_because_of_resize_;
85 bool all_active_child_surfaces_ready_to_draw_; 101 bool has_pending_surfaces_;
102
103 struct SurfaceBeginFrameState {
104 BeginFrameArgs last_args;
105 BeginFrameAck last_ack;
106 };
107 base::flat_map<SurfaceId, SurfaceBeginFrameState> surface_states_;
86 108
87 int next_swap_id_; 109 int next_swap_id_;
88 int pending_swaps_; 110 int pending_swaps_;
89 int max_pending_swaps_; 111 int max_pending_swaps_;
90 112
91 bool observing_begin_frame_source_; 113 bool observing_begin_frame_source_;
92 114
93 SurfaceId root_surface_id_; 115 SurfaceId root_surface_id_;
94 bool root_surface_damaged_;
95 bool expect_damage_from_root_surface_;
96
97 std::set<SurfaceId> child_surface_ids_damaged_;
98 std::set<SurfaceId> child_surface_ids_damaged_prev_;
99 std::vector<SurfaceId> child_surface_ids_to_expect_damage_from_;
100 116
101 base::WeakPtrFactory<DisplayScheduler> weak_ptr_factory_; 117 base::WeakPtrFactory<DisplayScheduler> weak_ptr_factory_;
102 118
103 private: 119 private:
104 DISALLOW_COPY_AND_ASSIGN(DisplayScheduler); 120 DISALLOW_COPY_AND_ASSIGN(DisplayScheduler);
105 }; 121 };
106 122
107 } // namespace cc 123 } // namespace cc
108 124
109 #endif // CC_SURFACES_DISPLAY_SCHEDULER_H_ 125 #endif // CC_SURFACES_DISPLAY_SCHEDULER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698