[cc] Plumb BeginFrameAcks through SurfaceManager to DisplayScheduler.

cc/surfaces/display.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/surfaces/display.h"
 
 #include <stddef.h>
 
 #include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 365 matching lines @@
 }
 
 void Display::DidReceiveTextureInUseResponses(
     const gpu::TextureInUseResponses& responses) {
   if (renderer_)
     renderer_->DidReceiveTextureInUseResponses(responses);
 }
 
 void Display::SetNeedsRedrawRect(const gfx::Rect& damage_rect) {
   aggregator_->SetFullDamageForSurface(current_surface_id_);
-  if (scheduler_)
-    scheduler_->SurfaceDamaged(current_surface_id_);
+  if (scheduler_) {
+    BeginFrameAck ack;
+    ack.has_damage = true;
+    scheduler_->SurfaceDamaged(current_surface_id_, ack, true);
+  }
 }
 
-void Display::OnSurfaceDamaged(const SurfaceId& surface_id, bool* changed) {
-  if (aggregator_ &&
-      aggregator_->previous_contained_surfaces().count(surface_id)) {
-    Surface* surface = surface_manager_->GetSurfaceForId(surface_id);
-    if (surface) {
-      if (!surface->HasActiveFrame() ||
-          surface->GetActiveFrame().resource_list.empty()) {
-        aggregator_->ReleaseResources(surface_id);
+void Display::OnSurfaceDamaged(const SurfaceId& surface_id,
+                               const BeginFrameAck& ack,
+                               bool* changed) {
+  if (ack.has_damage) {
+    if (aggregator_ &&
+        aggregator_->previous_contained_surfaces().count(surface_id)) {
+      Surface* surface = surface_manager_->GetSurfaceForId(surface_id);
+      if (surface) {
+        if (!surface->HasActiveFrame() ||

[sunnyps, 2017/05/25 20:49:13]

nit: Can surface->HasActiveFrame() be false? If not, can we
DCHECK(surface->HasActiveFrame())?

[Eric Seckler, 2017/05/26 10:57:52]

I think the only place where that may happen is when
CFSS::RequestCopyOfSurface() is called while there's no active frame on its
current_surface_.

I'm adding a conditional there, since it doesn't make sense to call
SurfaceDamaged() if there's no active frame.

Done.

+            surface->GetActiveFrame().resource_list.empty()) {
+          aggregator_->ReleaseResources(surface_id);
+        }
       }
+      *changed = true;
+    } else if (surface_id == current_surface_id_) {
+      *changed = true;
     }
-    if (scheduler_)
-      scheduler_->SurfaceDamaged(surface_id);
-    *changed = true;
-  } else if (surface_id == current_surface_id_) {
-    if (scheduler_)
-      scheduler_->SurfaceDamaged(surface_id);
-    *changed = true;
   }
 
+  if (scheduler_)
+    scheduler_->SurfaceDamaged(surface_id, ack, *changed);
+
   if (surface_id == current_surface_id_)
     UpdateRootSurfaceResourcesLocked();
 }
 
-void Display::OnSurfaceCreated(const SurfaceInfo& surface_info) {}
+bool Display::SurfaceHasUndrawnFrame(const SurfaceId& surface_id) const {
+  if (!surface_manager_)
+    return false;
+
+  Surface* surface = surface_manager_->GetSurfaceForId(surface_id);
+  if (!surface)
+    return false;
+
+  return surface->HasUndrawnActiveFrame();
+}
+
+void Display::OnSurfaceCreated(const SurfaceInfo& surface_info) {
+  if (scheduler_)
+    scheduler_->SurfaceCreated(surface_info);
+}
+
+void Display::OnSurfaceDestroyed(const SurfaceId& surface_id) {
+  if (scheduler_)
+    scheduler_->SurfaceDestroyed(surface_id);
+}
+
+void Display::OnSurfaceDamageExpected(const SurfaceId& surface_id,
+                                      const BeginFrameArgs& args) {
+  if (scheduler_)
+    scheduler_->SurfaceDamageExpected(surface_id, args);
+}
 
 void Display::OnSurfaceDiscarded(const SurfaceId& surface_id) {
   if (aggregator_)
     aggregator_->ReleaseResources(surface_id);
 }
 
 const SurfaceId& Display::CurrentSurfaceId() {
   return current_surface_id_;
 }
 
 void Display::ForceImmediateDrawAndSwapIfPossible() {
   if (scheduler_)
     scheduler_->ForceImmediateSwapIfPossible();
 }
 
 }  // namespace cc